All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch V2 2/2] i2c: mv64xxx: Remove internal compatible string from Documentation
Date: Mon, 28 Jul 2014 17:52:56 +0200	[thread overview]
Message-ID: <20140728155256.GH2891@lunn.ch> (raw)
In-Reply-To: <30588206.eyRbtryspM@wuerfel>

> > We don't translate into 'Marketing names'. We just turn the register
> > values into a stringified number. So it would have to be something
> > like:
> > 
> >         if (soc_name_is("7826") && soc_revision_is("1"))
> 
> Hmm, I think that is inconsistent with how the strings are used
> on other platforms, where you want something that uniquely identifies
> the device in user-readable strings.

Unfortunately, it is not so simple. There are a few different Armada
XP SoCs. E.g. dual core and quad core. And this is pretty normal for
Marvell. There are maybe 5 different Kirkwoods, a few different
Orion5x etc. So at minimum it would of had to be e.g. "Armada XP
7826".

However, it is too late now. This is part of the ABI, and Debian's
flash-kernel is making use of this in order to get the right DT blob.
So we cannot change it.

   Andrew

  reply	other threads:[~2014-07-28 15:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-26 17:20 [Patch V2 0/2] Generalize use of i2c quirk for Armada XP Andrew Lunn
2014-07-26 17:20 ` [Patch V2 1/2] ARM: mvebu: armada xp: Generalize use of i2c quirk Andrew Lunn
2014-10-15 15:25   ` Jason Cooper
2014-07-26 17:20 ` [Patch V2 2/2] i2c: mv64xxx: Remove internal compatible string from Documentation Andrew Lunn
2014-07-28 13:22   ` Jason Cooper
2014-07-28 13:27     ` Andrew Lunn
2014-07-28 13:51       ` Arnd Bergmann
2014-07-28 14:12         ` Andrew Lunn
2014-07-28 14:35           ` Arnd Bergmann
2014-07-28 15:25             ` Andrew Lunn
2014-07-28 15:47               ` Arnd Bergmann
2014-07-28 15:52                 ` Andrew Lunn [this message]
2014-07-28 16:03                   ` Arnd Bergmann
2014-07-28 18:29         ` Jason Gunthorpe
2014-07-29 10:21           ` Arnd Bergmann
2014-07-30  8:44         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140728155256.GH2891@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.