Re: [PATCH v8 0/6] xen: systemd support

["Luis R. Rodriguez" <mcgrof@suse.com>]

On Mon, Jul 28, 2014 at 05:57:56PM +0100, Andrew Cooper wrote:
> On 28/07/14 17:52, Andrew Cooper wrote:
> > On 28/07/14 13:46, Ian Campbell wrote:
> >> On Fri, 2014-07-25 at 19:14 -0700, Luis R. Rodriguez wrote:
> >>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >>>
> >>> Here's my v8 series. Quite a bit of patches are alreayd merged
> >>> on the xen origin/staging branch, this addresses the last feedback
> >>> from the v7 series and is rebased. It contains two fixes spotted
> >>> as possible issues by Ian Campbell.
> >>>
> >>> I think this is it, after about 2 months of spinning patches. Phew.
> >> I was about to ack and apply the lot when I noticed that
> >> dist/install/etc/init.d/xencommons was an empty file. I didn't analyse
> >> which patch it was, but I guessed at "move module list into a generic
> >> place" and reverting to the patch before that worked, so I've pushed
> >> just those, specifically:
> >>
> >> 54f2891 autoconf: xen: move standard path variables to config/Paths.mk
> >> 1846031 oxenstored: also fail if only 1 socket was given by systemd
> >> bdc74c9 cxenstored: also fail if only 1 socket was given by systemd
> >>
> >> I'm a little concerned by the recent lack of comments from systemd folks
> >> on the final patch, but there didn't seem much benefit in waiting any
> >> longer. Presumably any issues will get shaken down as people test etc.
> >>
> >> Thanks!
> >>
> >> Ian.
> > 54f2891 autoconf: xen: move standard path variables to config/Paths.mk
> >
> > has caused quite a lot of collateral damage on my dev tree.  Cheif
> > amongst the problems is:
> >
> > andrewcoop@andrewcoop:/local/xen.git/tools$ make clean
> > /local/xen.git/tools/../tools/Rules.mk:8:
> > /local/xen.git/tools/../config/Paths.mk: No such file or directory
> > make: *** No rule to make target
> > `/local/xen.git/tools/../config/Paths.mk'.  Stop.
> >
> > Running ./configure (without any arguments) does not generate Paths.mk
> > from Paths.mk.in, which means that I still cant `make clean`
> >
> > ~Andrew
> 
> andrewcoop@andrewcoop:/local/xen.git/tools$ git diff
> diff --git a/tools/Rules.mk b/tools/Rules.mk
> index 0aa1e6b..5bac700 100644
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -5,7 +5,7 @@ all:
>  
>  -include $(XEN_ROOT)/config/Tools.mk
>  include $(XEN_ROOT)/Config.mk
> -include $(XEN_ROOT)/config/Paths.mk
> +-include $(XEN_ROOT)/config/Paths.mk
>  
>  export _INSTALL := $(INSTALL)
>  INSTALL = $(XEN_ROOT)/tools/cross-install
> 
> Allows `make clean` to work correctly, but I still can't convince
> ./configure to create Paths.mk

Did you run autogen.sh?

  Luis