From: joeyli <jlee@suse.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 04/15] acer-wmi: Hide acer_{suspend,resume} for !CONFIG_PM_SLEEP
Date: Tue, 29 Jul 2014 11:21:59 +0800 [thread overview]
Message-ID: <20140729032159.GN24967@linux-rxt1.site> (raw)
In-Reply-To: <1405532597-28262-5-git-send-email-minipli@googlemail.com>
On Wed, Jul 16, 2014 at 07:43:06PM +0200, Mathias Krause wrote:
> Encapsulate acer_suspend() and acer_resume with #ifdef CONFIG_PM_SLEEP
> to get rid of the following warnings:
>
> ../acer-wmi.c:2046:12: warning: ‘acer_suspend’ defined but not used [-Wunused-function]
> ../acer-wmi.c:2068:12: warning: ‘acer_resume’ defined but not used [-Wunused-function]
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> Cc: "Lee, Chun-Yi" <jlee@suse.com>
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
Thanks a lot!
Joey Lee
> ---
> drivers/platform/x86/acer-wmi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index fde69ee63f..0d18c23d66 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -2044,6 +2044,7 @@ static int acer_platform_remove(struct platform_device *device)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> static int acer_suspend(struct device *dev)
> {
> u32 value;
> @@ -2084,6 +2085,10 @@ static int acer_resume(struct device *dev)
>
> return 0;
> }
> +#else
> +#define acer_suspend NULL
> +#define acer_resume NULL
> +#endif
>
> static SIMPLE_DEV_PM_OPS(acer_pm, acer_suspend, acer_resume);
>
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2014-07-29 3:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 17:43 [PATCH 00/15] Random collection of x86 platform driver cleanups Mathias Krause
2014-07-16 17:43 ` [PATCH 01/15] MAINTAINERS: Update git URL for x86 platform drivers Mathias Krause
2014-07-16 17:43 ` [PATCH 02/15] acer-wmi: Mark init data and code as such Mathias Krause
2014-07-29 3:18 ` joeyli
2014-07-16 17:43 ` [PATCH 03/15] acer-wmi: Mark acer_wmi_keymap[] as __initconst Mathias Krause
2014-07-29 3:21 ` joeyli
2014-07-16 17:43 ` [PATCH 04/15] acer-wmi: Hide acer_{suspend,resume} for !CONFIG_PM_SLEEP Mathias Krause
2014-07-29 3:21 ` joeyli [this message]
2014-07-16 17:43 ` [PATCH 05/15] alienware-wmi: Mark DMI table as __initconst Mathias Krause
2014-07-16 17:43 ` [PATCH 06/15] asus-nb-wmi: Constify asus_quirks[] DMI table Mathias Krause
2014-07-16 17:43 ` [PATCH 07/15] dell-laptop: Mark dell_quirks[] DMI table as __initconst Mathias Krause
2014-07-16 17:43 ` [PATCH 08/15] eeepc-wmi: Constify asus_quirks[] DMI table Mathias Krause
2014-07-16 17:43 ` [PATCH 09/15] fujitsu-laptop: Mark fujitsu_dmi_table[] DMI table as __initconst Mathias Krause
2014-07-16 22:59 ` Jonathan Woithe
2014-07-16 17:43 ` [PATCH 10/15] fujitsu-tablet: Mark DMI callbacks as __init code Mathias Krause
2014-07-16 17:43 ` [PATCH 11/15] hp-wmi: Add missing __init annotations to initialization code Mathias Krause
2014-07-16 17:43 ` [PATCH 12/15] hp_accel: Constify ACPI and DMI tables Mathias Krause
2014-07-16 17:43 ` [PATCH 13/15] ideapad-laptop: Constify DMI table and other r/o variables Mathias Krause
2014-07-16 17:43 ` [PATCH 14/15] intel_ips: Make ips_mcp_limits variables static Mathias Krause
2014-07-16 17:43 ` [PATCH 15/15] thinkpad_acpi: Mark volume_alsa_control_{vol,mute} as __initdata Mathias Krause
2014-07-16 19:03 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729032159.GN24967@linux-rxt1.site \
--to=jlee@suse.com \
--cc=matthew.garrett@nebula.com \
--cc=minipli@googlemail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.