From: Thierry Reding <thierry.reding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pwm@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v3 0/2] pwm: lpss: split driver to core and probe drivers
Date: Tue, 29 Jul 2014 12:10:24 +0200 [thread overview]
Message-ID: <20140729101022.GA21182@ulmo.nvidia.com> (raw)
In-Reply-To: <1406624231.8530.55.camel@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]
On Tue, Jul 29, 2014 at 11:57:11AM +0300, Andy Shevchenko wrote:
> On Mon, 2014-07-28 at 17:29 +0200, Thierry Reding wrote:
> > On Mon, Jul 28, 2014 at 06:03:10PM +0300, Andy Shevchenko wrote:
> > > This small series makes the architecture of pwm-lpss driver cleaner.
> > >
> > > Since v2:
> > > - fix one more typo in Kconfig (tested with one line removed in my config now)
> > >
> > > Since v1:
> > > - hide struct definition in the core part
> > > - rename pwm-lpss-plat to pwm-lpss-platform
> > > - fix Kconfig dependencies and other typos
> > > - add Mika's Reviewed-by tag
> > > - fix spelling in the commit messages
> > >
> > > Andy Shevchenko (2):
> > > pwm: lpss: properly split driver to parts
> > > pwm: lpss: pci: move to use pcim_enable_device()
> > >
> > > drivers/pwm/Kconfig | 21 ++++++-
> > > drivers/pwm/Makefile | 2 +
> > > drivers/pwm/pwm-lpss-pci.c | 68 ++++++++++++++++++++++
> > > drivers/pwm/pwm-lpss-platform.c | 61 ++++++++++++++++++++
> > > drivers/pwm/pwm-lpss.c | 125 ++--------------------------------------
> > > drivers/pwm/pwm-lpss.h | 29 ++++++++++
> > > 6 files changed, 186 insertions(+), 120 deletions(-)
> > > create mode 100644 drivers/pwm/pwm-lpss-pci.c
> > > create mode 100644 drivers/pwm/pwm-lpss-platform.c
> > > create mode 100644 drivers/pwm/pwm-lpss.h
> >
> > I'd like an Acked-by from Alan on this since he had strong objections
> > when I requested exactly this a while back.
>
> Meanwhile he is in Cc list, could you share the link to the previous
> discussion?
See: http://patchwork.ozlabs.org/patch/339493/
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-29 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 15:03 [PATCH v3 0/2] pwm: lpss: split driver to core and probe drivers Andy Shevchenko
2014-07-28 15:03 ` [PATCH v3 1/2] pwm: lpss: properly split driver to parts Andy Shevchenko
2014-07-28 15:34 ` Mika Westerberg
2014-07-28 15:03 ` [PATCH v3 2/2] pwm: lpss: pci: move to use pcim_enable_device() Andy Shevchenko
2014-07-28 15:29 ` [PATCH v3 0/2] pwm: lpss: split driver to core and probe drivers Thierry Reding
2014-07-29 8:57 ` Andy Shevchenko
2014-07-29 10:10 ` Thierry Reding [this message]
2014-07-29 11:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729101022.GA21182@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.