All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, adilger@dilger.ca, lczerner@redhat.com
Subject: Re: [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g_ex
Date: Tue, 29 Jul 2014 09:58:19 -0400	[thread overview]
Message-ID: <20140729135819.GA2256@thunk.org> (raw)
In-Reply-To: <1406108861-2581-1-git-send-email-wangxg.fnst@cn.fujitsu.com>

On Wed, Jul 23, 2014 at 05:47:41PM +0800, Xiaoguang Wang wrote:
> In ext4_mb_normalize_request(), if ac_g_ex.fe_logical is adjacent to the closest logical
> allocated block to the left or (ac_g_ex.fe_logical+len) adjacent to the closest logical
> allocated block to the right, we'll attach EXT4_MB_HINT_TRY_GOAL flag taking the physical
> block (ext4_allocation_request.lleft+1) or (ext4_allocation_request.pright-len) as a goal,
> and put this information in ext4_allocation_context.ac_f_ex.
> 
> But look at the ext4_mb_find_by_goal(), indeed it use ac_g_ex to look up, so this is wrong,
> we should save goal group and offset in struct ext4_allocation_context.ac_g_ex.
> 
> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>

Nice catch!

Thanks, applied.

					- Ted

  reply	other threads:[~2014-07-29 13:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23  9:47 [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g_ex Xiaoguang Wang
2014-07-29 13:58 ` Theodore Ts'o [this message]
2014-07-31 15:32   ` Theodore Ts'o
2014-08-01  1:13     ` Xiaoguang Wang
2014-08-01 12:40       ` Theodore Ts'o
2014-08-04  7:00     ` Xiaoguang Wang
2014-08-04 10:39       ` [PATCH v2] " Xiaoguang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729135819.GA2256@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=wangxg.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.