From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1XC9v6-0007w5-D1
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1XC9uw-0003RM-Pr
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:06:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13944)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1XC9uw-0003RA-IH
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:06:22 -0400
Date: Tue, 29 Jul 2014 18:06:14 +0200
From: Andrew Jones <drjones@redhat.com>
Message-ID: <20140729160613.GA5626@hawk.usersys.redhat.com>
References: <1406648690-8880-1-git-send-email-drjones@redhat.com>
	<CAFEAcA-SZOKtp64WOQHr5VfhYofr0AyikpeeuSaZd=E-KzK+_A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-SZOKtp64WOQHr5VfhYofr0AyikpeeuSaZd=E-KzK+_A@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: fix pl031 addr typo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Tue, Jul 29, 2014 at 04:58:44PM +0100, Peter Maydell wrote:
> On 29 July 2014 16:44, Andrew Jones <drjones@redhat.com> wrote:
> > pl031's base address should be 0x9001000, 0x90010000. While in there
                                             ^ meant to type 'not' here,
but guess that was obvious
> > also add some spacing and zeros to make it easier to read the map.

I can send two separate patches for the fix and the formatting, but
you'd still have to check the formatting patch closely to make sure
nothing else changed...

> >
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > -    [VIRT_RTC] = { 0x90010000, 0x1000 },
> > +    [VIRT_RTC] =        { 0x09001000, 0x00001000 },
> 
> ...and assuming from the commit message that this is the
> only actual change, the alignment to 64K is deliberate,
> for the benefit of guests with 64K pages.

0K, so it needs to be 0x09010000, which is still not what it is.
As it is right now it's sitting in RAM, when configuring a guest
to have greater than 1G.

drew

> 
> thanks
> -- PMM
>