From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/2] drm/i915: timespec_sub should already be normalized
Date: Tue, 29 Jul 2014 23:29:26 -0700 [thread overview]
Message-ID: <20140730062926.GB1828@intel.com> (raw)
In-Reply-To: <20140730061505.GH21570@nuc-i3427.alporthouse.com>
On Wed, Jul 30, 2014 at 07:15:05AM +0100, Chris Wilson wrote:
> On Tue, Jul 29, 2014 at 01:14:29PM -0700, Ben Widawsky wrote:
> > So don't bother checking it again.
> > This was introduced:
> > commit b361237bcc7cea1d99f770490120d8bc2aed7777
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Fri Aug 24 09:35:08 2012 +0100
> >
> > drm/i915: Juggle code order to ease flow of the next patch
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> Ah, it is not so much that the timeout may be unnormalized, but that it
> *may* be negative.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
>From looking at the code, I thought it didn't matter (ie. I thought it
dtrt regardless of negative). However, I just wrote a little test, and
you are correct. It is needed. Sorry about that.
--
Ben Widawsky, Intel Open Source Technology Center
prev parent reply other threads:[~2014-07-30 6:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 20:14 [PATCH 1/2] drm/i915: timespec_sub should already be normalized Ben Widawsky
2014-07-29 20:14 ` [PATCH 2/2] drm/i915: Embellish wait_end trace Ben Widawsky
2014-07-30 6:19 ` Chris Wilson
2014-07-30 6:33 ` Ben Widawsky
2014-07-30 6:47 ` Chris Wilson
2014-07-30 6:15 ` [PATCH 1/2] drm/i915: timespec_sub should already be normalized Chris Wilson
2014-07-30 6:29 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730062926.GB1828@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.