From: Lee Jones <lee.jones@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] mfd: ab8500-core: Use 'ifdef' for config options
Date: Wed, 30 Jul 2014 08:25:04 +0100 [thread overview]
Message-ID: <20140730072504.GD9030@lee--X1> (raw)
In-Reply-To: <1406683788-7776-1-git-send-email-festevam@gmail.com>
On Tue, 29 Jul 2014, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> The config symbol 'CONFIG_DEBUG_FS' should be protected by a 'ifdef' instead
> of a plain 'if'.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/ab8500-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index ce48aa7..bde2fc0 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -1754,7 +1754,7 @@ static int ab8500_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> -#if CONFIG_DEBUG_FS
> +#ifdef CONFIG_DEBUG_FS
> /* Pass to debugfs */
> ab8500_debug_resources[0].start = ab8500->irq;
> ab8500_debug_resources[0].end = ab8500->irq;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-07-30 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 1:29 [PATCH] mfd: ab8500-core: Use 'ifdef' for config options Fabio Estevam
2014-07-30 7:25 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730072504.GD9030@lee--X1 \
--to=lee.jones@linaro.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.