From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary braces
Date: Wed, 30 Jul 2014 17:09:14 +0300 [thread overview]
Message-ID: <20140730140914.GK4856@mwanda> (raw)
In-Reply-To: <53D8FB53.3050501@mev.co.uk>
On Wed, Jul 30, 2014 at 03:04:03PM +0100, Ian Abbott wrote:
> On 2014-07-30 14:41, Dan Carpenter wrote:
> >On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
> >>Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> >>---
> >>v2: Be less aggressive in brace removal. Keep them for outer nested
> >>'if's. Keep them in outer control statements where the inner control
> >>statement uses braces.
> >
> >Really every multi-line indent should have braces for readability. This
> >isn't documented anywhere, but it's normal kernel style and Greg prefers
> >it for staging as well but I can't find the URL on google where he
> >mentioned that.
>
> With this version of the patch, amplc_pci230.c conforms to that --
> as long as you don't count comments, or splitting a simple statement
> across multiple lines to fit within 80 columns, e.g.:
>
> if (foo)
> /* do this */
> bar = baz +
> qux;
Heh... I am counting comments and broken lines, though. It's not a
totally strict rule and it's especially not strict for broken lines.
But we would prefer braces in those situations.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-30 14:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 11:58 [PATCH 00/19] staging: comedi: amplc_pci230: tidy up a bit Ian Abbott
2014-07-29 11:58 ` [PATCH 01/19] staging: comedi: amplc_pci230: reformat a load of comments Ian Abbott
2014-07-29 11:58 ` [PATCH 02/19] staging: comedi: amplc_pci230: fix checkpatch line over 80 characters Ian Abbott
2014-07-29 11:58 ` [PATCH 03/19] staging: comedi: amplc_pci230: logical continuations should be on the previous line Ian Abbott
2014-07-29 11:58 ` [PATCH 04/19] staging: comedi: amplc_pci230: blank lines aren't necessary before a close brace '}' Ian Abbott
2014-07-29 11:58 ` [PATCH 05/19] staging: comedi: amplc_pci230: alignment should match open parenthesis Ian Abbott
2014-07-29 11:58 ` [PATCH 06/19] staging: comedi: amplc_pci230: usleep_range is preferred over udelay Ian Abbott
2014-07-29 11:58 ` [PATCH 07/19] staging: comedi: amplc_pci230: remove unused settling time constants Ian Abbott
2014-07-29 11:58 ` [PATCH 08/19] staging: comedi: amplc_pci230: remove PCI230_ADC_CONV Ian Abbott
2014-07-29 11:58 ` [PATCH 09/19] staging: comedi: amplc_pci230: remove PCI230_TEST_BIT() Ian Abbott
2014-07-29 11:58 ` [PATCH 10/19] staging: comedi: amplc_pci230: add whitespace to register values Ian Abbott
2014-07-29 11:58 ` [PATCH 11/19] staging: comedi: amplc_pci230: don't begin line with binary operator Ian Abbott
2014-07-29 11:58 ` [PATCH 12/19] staging: comedi: amplc_pci230: omit '!= 0' from logical expressions Ian Abbott
2014-07-29 11:58 ` [PATCH 13/19] staging: comedi: amplc_pci230: remove unnecessary braces Ian Abbott
2014-07-30 0:34 ` Hartley Sweeten
2014-07-30 11:53 ` [PATCH 13/19 v2] " Ian Abbott
2014-07-30 13:41 ` Dan Carpenter
2014-07-30 14:04 ` Ian Abbott
2014-07-30 14:09 ` Dan Carpenter [this message]
2014-07-30 14:27 ` Ian Abbott
2014-07-30 16:15 ` Hartley Sweeten
2014-07-30 23:53 ` Greg Kroah-Hartman
2014-07-29 11:58 ` [PATCH 14/19] staging: comedi: amplc_pci230: remove some indentation in pci230_ai_check_chanlist() Ian Abbott
2014-07-29 11:58 ` [PATCH 15/19] staging: comedi: amplc_pci230: no need for '&function' Ian Abbott
2014-07-29 11:58 ` [PATCH 16/19] staging: comedi: amplc_pci230: add whitespace to pci230_boards[] Ian Abbott
2014-07-29 11:58 ` [PATCH 17/19] staging: comedi: amplc_pci230: no need to initialize named members to zero Ian Abbott
2014-07-29 11:58 ` [PATCH 18/19] staging: comedi: amplc_pci230: tidy up stuct pci230_private Ian Abbott
2014-07-29 11:58 ` [PATCH 19/19] staging: comedi: amplc_pci230: remove some unnecessary parentheses Ian Abbott
2014-07-30 11:55 ` [PATCH 19/19 v2] " Ian Abbott
2014-07-30 0:54 ` [PATCH 00/19] staging: comedi: amplc_pci230: tidy up a bit Hartley Sweeten
2014-07-30 12:00 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730140914.GK4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.