From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: CCI: Correct use of ! and &
Date: Wed, 30 Jul 2014 12:54:24 -0700 [thread overview]
Message-ID: <20140730195424.GG18384@quad.lixom.net> (raw)
In-Reply-To: <1406716655-32494-1-git-send-email-punit.agrawal@arm.com>
On Wed, Jul 30, 2014 at 11:37:35AM +0100, Punit Agrawal wrote:
> From: Himangi Saraogi <himangi774@gmail.com>
>
> In commit ae91d60ba88ef0bdb1b5e9b2363bd52fc45d2af7, a bug was fixed that
> involved converting !x & y to !(x & y). The code below shows the same
> pattern, and thus should perhaps be fixed in the same way.
>
> The Coccinelle semantic patch that makes this change is as follows:
>
> // <smpl>
> @@ expression E1,E2; @@
> (
> !E1 & !E2
> |
> - !E1 & E2
> + !(E1 & E2)
> )
> // </smpl>
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> Acked-by: Punit Agrawal <punit.agrawal@arm.com>
> ---
Thanks, applied (adding a Fixes: tag, please use those in the future)
-Olof
next prev parent reply other threads:[~2014-07-30 19:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 10:37 [PATCH] drivers: CCI: Correct use of ! and & Punit Agrawal
2014-07-30 19:54 ` Olof Johansson [this message]
2014-07-31 6:00 ` Olof Johansson
2014-07-31 15:38 ` Punit Agrawal
-- strict thread matches above, loose matches on Subject: below --
2014-07-07 14:05 Himangi Saraogi
2014-07-23 15:01 ` Punit Agrawal
2014-07-23 15:01 ` Punit Agrawal
2014-07-23 15:05 ` Will Deacon
2014-07-23 15:05 ` Will Deacon
2014-07-29 11:34 ` Punit Agrawal
2014-07-29 11:34 ` Punit Agrawal
2014-07-29 16:41 ` Olof Johansson
2014-07-29 16:41 ` Olof Johansson
2014-07-30 10:32 ` Punit Agrawal
2014-07-30 10:32 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730195424.GG18384@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.