From: Greg KH <gregkh@linuxfoundation.org>
To: "Fernando Apesteguía" <fernando.apesteguia@gmail.com>
Cc: Guillaume Clement <gclement@baobob.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6655: staticfy variable
Date: Wed, 30 Jul 2014 17:04:40 -0700 [thread overview]
Message-ID: <20140731000440.GA17081@kroah.com> (raw)
In-Reply-To: <CAGwOe2Yhd896GWU=2j2dw+PFgCS1mmP+vkZaoLKed54zi7US2Q@mail.gmail.com>
On Wed, Jul 30, 2014 at 11:20:49PM +0200, Fernando Apesteguía wrote:
> On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement <gclement@baobob.org> wrote:
> > Hello,
> >
> >> Add static to variable.
> >> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> >> ---
> >> drivers/staging/vt6655/ioctl.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6655/ioctl.c
> >> b/drivers/staging/vt6655/ioctl.c
> >> index 65e5933..cc6e47b 100644
> >> --- a/drivers/staging/vt6655/ioctl.c
> >> +++ b/drivers/staging/vt6655/ioctl.c
> >> @@ -41,7 +41,7 @@
> >> static int msglevel = MSG_LEVEL_INFO;
> >>
> >> #ifdef WPA_SM_Transtatus
> >> -SWPAResult wpa_Result;
> >> +static SWPAResult wpa_Result;
> >> #endif
> >
> > This changes breaks the compilation (actually the linking). wpa_Result
> > is actually used in device_main.c in device_open with the following:
>
> Argh... sorry, I missed that.
ALWAYS test-build your patches, don't make me be your first tester...
next prev parent reply other threads:[~2014-07-31 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 19:16 [PATCH] Staging: vt6655: staticfy variable Guillaume Clement
2014-07-30 21:20 ` Fernando Apesteguía
2014-07-31 0:04 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-30 16:51 fernando.apesteguia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731000440.GA17081@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fernando.apesteguia@gmail.com \
--cc=gclement@baobob.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.