All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Use shmobile_init_delay() on APE6EVM
Date: Thu, 31 Jul 2014 00:12:25 +0000	[thread overview]
Message-ID: <20140731001221.GA893@verge.net.au> (raw)
In-Reply-To: <20140511231050.19908.86623.sendpatchset@w520>

On Thu, Jul 31, 2014 at 08:45:00AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> The r8a73a4 DTS includes CPU Frequency information so
> adjust the APE6EVM board code to use shmobile_init_delay()
> instead of relying on CPU Frequency information included
> in r8a73a4_init_delay() that is specified in C.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> 
>  Written on top of renesas-devel-v3.16-rc7-20140729 and
>  [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()

Hi Magnus,

As per my comment on "[PATCH 00/09] ARM: shmobile: Consistent use of
shmobile_init_late()".

These patches seem fine for me but I wonder if you could follow the
convention that has emerged as being dominant for subjects

* Using lowercase for SOC names
* Omitting hyphens from boards names (i.e. bockw)
* Putting the board or soc after "shmobile: " and followed by a ':'.

I have taken the liberty of updating the patch name to the
following and queued up the result:

ARM: shmobile: ape6evm: Use shmobile_init_delay()

      parent reply	other threads:[~2014-07-31  0:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-11 23:10 [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740 Magnus Damm
2014-05-11 23:10 ` Magnus Damm
2014-05-12  7:42 ` Geert Uytterhoeven
2014-05-12  7:42   ` Geert Uytterhoeven
2014-05-13  8:10   ` Simon Horman
2014-05-13  8:10     ` Simon Horman
2014-05-16  4:08     ` Simon Horman
2014-05-16  4:08       ` Simon Horman
2014-05-16  4:39       ` Magnus Damm
2014-05-16  4:39         ` Magnus Damm
2014-05-16  4:45         ` Simon Horman
2014-05-16  4:45           ` Simon Horman
2014-05-16  4:48           ` Magnus Damm
2014-05-16  4:48             ` Magnus Damm
2014-05-16  6:13             ` Simon Horman
2014-05-16  6:13               ` Simon Horman
2014-06-06  6:15 ` [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7791 DT-only Magnus Damm
2014-07-30 23:45 ` [PATCH] ARM: shmobile: Use shmobile_init_delay() on APE6EVM Magnus Damm
2014-07-31  0:12 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731001221.GA893@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.