All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: spbnick@gmail.com
Cc: linux-input@vger.kernel.org
Subject: re: HID: huion: Switch to generating report descriptor
Date: Thu, 31 Jul 2014 12:40:12 +0300	[thread overview]
Message-ID: <20140731094012.GH30276@mwanda> (raw)

Hello Nikolai Kondrashov,

The patch f8dd5cb2c6d0: "HID: huion: Switch to generating report
descriptor" from Jul 23, 2014, leads to the following static checker
warning:

	drivers/hid/hid-huion.c:126 huion_tablet_enable()
	error: doing dma on the stack (buf)

drivers/hid/hid-huion.c
   113  static int huion_tablet_enable(struct hid_device *hdev)
   114  {
   115          int rc;
   116          struct usb_device *usb_dev = hid_to_usb_dev(hdev);
   117          struct huion_drvdata *drvdata = hid_get_drvdata(hdev);
   118          __le16 buf[6];
   119  
   120          /*
   121           * Read string descriptor containing tablet parameters. The specific
   122           * string descriptor and data were discovered by sniffing the Windows
   123           * driver traffic.
   124           * NOTE: This enables fully-functional tablet mode.
   125           */
   126          rc = usb_control_msg(usb_dev, usb_rcvctrlpipe(usb_dev, 0),
   127                                  USB_REQ_GET_DESCRIPTOR, USB_DIR_IN,
   128                                  (USB_DT_STRING << 8) + 0x64,
   129                                  0x0409, buf, sizeof(buf),
                                                ^^^
   130                                  USB_CTRL_GET_TIMEOUT);

regards,
dan carpenter

             reply	other threads:[~2014-07-31  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  9:40 Dan Carpenter [this message]
2014-08-11 18:09 ` HID: huion: Switch to generating report descriptor Nikolai Kondrashov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731094012.GH30276@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-input@vger.kernel.org \
    --cc=spbnick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.