Re: [PATCH v2 2/4] KVM: ARM: vgic: register kvm_device_ops dynamically

[Will Deacon <will.deacon@arm.com>]

Hi Christoffer,

On Thu, Jul 31, 2014 at 01:10:15PM +0100, Christoffer Dall wrote:
> On Tue, Jul 01, 2014 at 03:45:16PM +0100, Will Deacon wrote:
> > Now that we have a dynamic means to register kvm_device_ops, use that
> > for the ARM VGIC, instead of relying on the static table.
> > 
> > Cc: Gleb Natapov <gleb@kernel.org>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Christoffer Dall <christoffer.dall@linaro.org>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> >  include/linux/kvm_host.h |   1 -
> >  virt/kvm/arm/vgic.c      | 156 +++++++++++++++++++++++------------------------
> >  virt/kvm/kvm_main.c      |   4 --
> >  3 files changed, 78 insertions(+), 83 deletions(-)

[...]

> > +	if (ret) {
> > +		kvm_err("Cannot register vgic CPU notifier\n");
> > +		goto out_free_irq;
> > +	}
> > +
> > +	on_each_cpu(vgic_init_maintenance_interrupt, NULL, 1);
> > +
> > +	/* Callback into for arch code for setup */
> > +	vgic_arch_setup(vgic);
> 
> close to ridiculous nit: but I would add a newline here since the
> comment doesn't really apply to the kvm_register_device_ops, but please
> don't make another revision just for this.

I'll repost this after the merge window anyway, so there's plenty of room
for pedantic, cosmetic changes!

Thanks,

Will