All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kishon@ti.com
Cc: linux-pci@vger.kernel.org
Subject: re: PCI: dra7xx: Add TI DRA7xx PCIe driver
Date: Thu, 31 Jul 2014 16:31:25 +0300	[thread overview]
Message-ID: <20140731133125.GA7434@mwanda> (raw)

Hello Kishon Vijay Abraham I,

The patch 47ff3de911a7: "PCI: dra7xx: Add TI DRA7xx PCIe driver" from
Jul 22, 2014, leads to the following static checker warning:

	drivers/pci/host/pci-dra7xx.c:180 dra7xx_pcie_init_irq_domain()
	warn: passing zero to 'PTR_ERR'

drivers/pci/host/pci-dra7xx.c
   172  static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp)
   173  {
   174          struct device *dev = pp->dev;
   175          struct device_node *node = dev->of_node;
   176          struct device_node *pcie_intc_node =  of_get_next_child(node, NULL);
   177  
   178          if (!pcie_intc_node) {
                     ^^^^^^^^^^^^^^
   179                  dev_err(dev, "No PCIe Intc node found\n");
   180                  return PTR_ERR(pcie_intc_node);
                                       ^^^^^^^^^^^^^^
   181          }
   182  
   183          pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
   184                                                 &intx_domain_ops, pp);
   185          if (!pp->irq_domain) {
   186                  dev_err(dev, "Failed to get a INTx IRQ domain\n");
   187                  return PTR_ERR(pp->irq_domain);
                                       ^^^^^^^^^^^^^^
Again.

   188          }
   189  
   190          return 0;

regards,
dan carpenter

                 reply	other threads:[~2014-07-31 13:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731133125.GA7434@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kishon@ti.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.