From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] staging: lustre: bitwise vs logical typo
Date: Thu, 31 Jul 2014 15:21:34 +0000 [thread overview]
Message-ID: <20140731152134.GC31539@mwanda> (raw)
Bitwise AND was intended here obviously.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. I wasn't able to compile this.
Also lustre needs an entry in MAINTAINERS because otherwise
get_maintainer.pl still sends everything to Peng Tao only.
diff --git a/drivers/staging/lustre/lustre/obdecho/echo.c b/drivers/staging/lustre/lustre/obdecho/echo.c
index f3b7429..dae1599 100644
--- a/drivers/staging/lustre/lustre/obdecho/echo.c
+++ b/drivers/staging/lustre/lustre/obdecho/echo.c
@@ -125,7 +125,7 @@ static int echo_create(const struct lu_env *env, struct obd_export *exp,
return -EINVAL;
}
- if (!(oa->o_mode && S_IFMT)) {
+ if (!(oa->o_mode & S_IFMT)) {
CERROR("echo obd: no type!\n");
return -ENOENT;
}
reply other threads:[~2014-07-31 15:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731152134.GC31539@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.