All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] xfs: kill VN_DIRTY()
Date: Thu, 31 Jul 2014 10:13:02 -0700	[thread overview]
Message-ID: <20140731171302.GA22173@infradead.org> (raw)
In-Reply-To: <1406791995-14723-4-git-send-email-david@fromorbit.com>

On Thu, Jul 31, 2014 at 05:33:12PM +1000, Dave Chinner wrote:
> -			if (VN_DIRTY(VFS_I(ip)) && ip->i_delayed_blks > 0) {
> +			if (mapping_tagged(VFS_I(ip)->i_mapping,
> +					   PAGECACHE_TAG_DIRTY) &&
> +			    ip->i_delayed_blks > 0) {
>  				error = filemap_flush(VFS_I(ip)->i_mapping);

I don't think there's even any point in keeping the mapping_tagged
check.  filemap_flush handles the case where nothing is to flush
internally, and no other callers others with things like this either.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-07-31 17:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  7:33 [PATCH 0/6] xfs: discombobulate sb updates and kill xfs_vnode.h Dave Chinner
2014-07-31  7:33 ` [PATCH 1/6] xfs: remove bitfield based superblock updates Dave Chinner
2014-08-01 14:37   ` Brian Foster
2014-08-04  7:34     ` Dave Chinner
2014-07-31  7:33 ` [PATCH 2/6] xfs: consolidate superblock logging functions Dave Chinner
2014-08-01 14:39   ` Brian Foster
2014-08-04  8:09     ` Dave Chinner
2014-08-04 12:48       ` Brian Foster
2014-08-04 22:15         ` Dave Chinner
2014-08-05  0:03           ` Brian Foster
2014-08-05  0:34             ` Dave Chinner
2014-08-05 12:30               ` Brian Foster
2014-08-05 19:59                 ` Dave Chinner
2014-08-06 11:41                   ` Brian Foster
2014-07-31  7:33 ` [PATCH 3/6] xfs: kill VN_DIRTY() Dave Chinner
2014-07-31 17:13   ` Christoph Hellwig [this message]
2014-08-04  3:20     ` [PATCH 3/6 V2] " Dave Chinner
2014-08-04 13:14       ` Christoph Hellwig
2014-07-31  7:33 ` [PATCH 4/6] xfs: kill VN_CACHED Dave Chinner
2014-07-31 17:13   ` Christoph Hellwig
2014-07-31  7:33 ` [PATCH 5/6] xfs: kill VN_MAPPED Dave Chinner
2014-07-31 17:14   ` Christoph Hellwig
2014-07-31  7:33 ` [PATCH 6/6] xfs: kill xfs_vnode.h Dave Chinner
2014-07-31 17:14   ` Christoph Hellwig
2014-07-31 17:16 ` [PATCH 0/6] xfs: discombobulate sb updates and " Christoph Hellwig
2014-07-31 23:01   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731171302.GA22173@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.