From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Thu, 31 Jul 2014 17:30:25 -0700 Subject: [PATCH 1/4] clk: rockchip: protect critical clocks from getting disabled In-Reply-To: <4047366.k35vzjcKGH@diego> References: <1406661128-7614-1-git-send-email-heiko@sntech.de> <1406661128-7614-2-git-send-email-heiko@sntech.de> <20140731224523.4463.34464@quantum> <4047366.k35vzjcKGH@diego> Message-ID: <20140801003025.4463.76384@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Heiko St?bner (2014-07-31 16:29:34) > Hi Mike, > > Am Donnerstag, 31. Juli 2014, 15:45:23 schrieb Mike Turquette: > > Quoting Heiko Stuebner (2014-07-29 12:12:05) > > > > > The clock-tree contains clocks that should never get disabled > > > automatically. One example are the base ACLKs, the base supplies for all > > > peripherals. > > > > > > Therefore add a structure similar to the sunxi clock-tree to protect these > > > special clocks from being disabled. > > > > > > Signed-off-by: Heiko Stuebner > > > --- > > > > > > drivers/clk/rockchip/clk-rk3188.c | 7 +++++++ > > > drivers/clk/rockchip/clk-rk3288.c | 7 +++++++ > > > drivers/clk/rockchip/clk.c | 13 +++++++++++++ > > > drivers/clk/rockchip/clk.h | 1 + > > > 4 files changed, 28 insertions(+) > > > > > > diff --git a/drivers/clk/rockchip/clk-rk3188.c > > > b/drivers/clk/rockchip/clk-rk3188.c index a83a6d8..5aef277 100644 > > > --- a/drivers/clk/rockchip/clk-rk3188.c > > > +++ b/drivers/clk/rockchip/clk-rk3188.c > > > @@ -599,6 +599,11 @@ static struct rockchip_clk_branch > > > rk3188_clk_branches[] __initdata = {> > > > GATE(ACLK_GPS, "aclk_gps", "aclk_peri", 0, RK2928_CLKGATE_CON(8), > > > 13, GFLAGS),> > > > }; > > > > > > +static const char *rk3188_critical_clocks[] __initconst = { > > > + "aclk_cpu", > > > + "aclk_peri", > > > > I'm not against the idea of critical clocks, but I want to verify that > > there is no other driver out there that is a better fit for claiming > > these clks via clk_get and enabling them the normal way via clk_enable? > > In the clock hierarchy of Rockchip SoCs, both aclks listed here, are sources > for pclk and hclk, as well as sourcing some other peripheral gates further > below too. So from what I've seen from the clock diagrams, there is nothing > that would claim these clocks directly, and it wouldn't also make any sense to > let them get disabled as there will always be something using them (for > example the dram-controller). Sounds good. Just out of curiosity, under what circumstances would you want to gate them? Is there a use case for it? Regards, Mike > > > Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH 1/4] clk: rockchip: protect critical clocks from getting disabled Date: Thu, 31 Jul 2014 17:30:25 -0700 Message-ID: <20140801003025.4463.76384@quantum> References: <1406661128-7614-1-git-send-email-heiko@sntech.de> <1406661128-7614-2-git-send-email-heiko@sntech.de> <20140731224523.4463.34464@quantum> <4047366.k35vzjcKGH@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4047366.k35vzjcKGH@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?utf-8?q?Heiko_St=C3=BCbner?= Cc: devicetree@vger.kernel.org, dianders@chromium.org, kever.yang@rock-chips.com, arm@kernel.org, cf@rock-chips.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org UXVvdGluZyBIZWlrbyBTdMO8Ym5lciAoMjAxNC0wNy0zMSAxNjoyOTozNCkKPiBIaSBNaWtlLAo+ IAo+IEFtIERvbm5lcnN0YWcsIDMxLiBKdWxpIDIwMTQsIDE1OjQ1OjIzIHNjaHJpZWIgTWlrZSBU dXJxdWV0dGU6Cj4gPiBRdW90aW5nIEhlaWtvIFN0dWVibmVyICgyMDE0LTA3LTI5IDEyOjEyOjA1 KQo+ID4gCj4gPiA+IFRoZSBjbG9jay10cmVlIGNvbnRhaW5zIGNsb2NrcyB0aGF0IHNob3VsZCBu ZXZlciBnZXQgZGlzYWJsZWQKPiA+ID4gYXV0b21hdGljYWxseS4gT25lIGV4YW1wbGUgYXJlIHRo ZSBiYXNlIEFDTEtzLCB0aGUgYmFzZSBzdXBwbGllcyBmb3IgYWxsCj4gPiA+IHBlcmlwaGVyYWxz Lgo+ID4gPiAKPiA+ID4gVGhlcmVmb3JlIGFkZCBhIHN0cnVjdHVyZSBzaW1pbGFyIHRvIHRoZSBz dW54aSBjbG9jay10cmVlIHRvIHByb3RlY3QgdGhlc2UKPiA+ID4gc3BlY2lhbCBjbG9ja3MgZnJv bSBiZWluZyBkaXNhYmxlZC4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEhlaWtvIFN0dWVi bmVyIDxoZWlrb0BzbnRlY2guZGU+Cj4gPiA+IC0tLQo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvY2xr L3JvY2tjaGlwL2Nsay1yazMxODguYyB8ICA3ICsrKysrKysKPiA+ID4gIGRyaXZlcnMvY2xrL3Jv Y2tjaGlwL2Nsay1yazMyODguYyB8ICA3ICsrKysrKysKPiA+ID4gIGRyaXZlcnMvY2xrL3JvY2tj aGlwL2Nsay5jICAgICAgICB8IDEzICsrKysrKysrKysrKysKPiA+ID4gIGRyaXZlcnMvY2xrL3Jv Y2tjaGlwL2Nsay5oICAgICAgICB8ICAxICsKPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMjggaW5z ZXJ0aW9ucygrKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL3JvY2tjaGlw L2Nsay1yazMxODguYwo+ID4gPiBiL2RyaXZlcnMvY2xrL3JvY2tjaGlwL2Nsay1yazMxODguYyBp bmRleCBhODNhNmQ4Li41YWVmMjc3IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2Nsay9yb2Nr Y2hpcC9jbGstcmszMTg4LmMKPiA+ID4gKysrIGIvZHJpdmVycy9jbGsvcm9ja2NoaXAvY2xrLXJr MzE4OC5jCj4gPiA+IEBAIC01OTksNiArNTk5LDExIEBAIHN0YXRpYyBzdHJ1Y3Qgcm9ja2NoaXBf Y2xrX2JyYW5jaAo+ID4gPiByazMxODhfY2xrX2JyYW5jaGVzW10gX19pbml0ZGF0YSA9IHs+IAo+ ID4gPiAgICAgICAgIEdBVEUoQUNMS19HUFMsICJhY2xrX2dwcyIsICJhY2xrX3BlcmkiLCAwLCBS SzI5MjhfQ0xLR0FURV9DT04oOCksCj4gPiA+ICAgICAgICAgMTMsIEdGTEFHUyksPiAgCj4gPiA+ ICB9Owo+ID4gPiAKPiA+ID4gK3N0YXRpYyBjb25zdCBjaGFyICpyazMxODhfY3JpdGljYWxfY2xv Y2tzW10gX19pbml0Y29uc3QgPSB7Cj4gPiA+ICsgICAgICAgImFjbGtfY3B1IiwKPiA+ID4gKyAg ICAgICAiYWNsa19wZXJpIiwKPiA+IAo+ID4gSSdtIG5vdCBhZ2FpbnN0IHRoZSBpZGVhIG9mIGNy aXRpY2FsIGNsb2NrcywgYnV0IEkgd2FudCB0byB2ZXJpZnkgdGhhdAo+ID4gdGhlcmUgaXMgbm8g b3RoZXIgZHJpdmVyIG91dCB0aGVyZSB0aGF0IGlzIGEgYmV0dGVyIGZpdCBmb3IgY2xhaW1pbmcK PiA+IHRoZXNlIGNsa3MgdmlhIGNsa19nZXQgYW5kIGVuYWJsaW5nIHRoZW0gdGhlIG5vcm1hbCB3 YXkgdmlhIGNsa19lbmFibGU/Cj4gCj4gSW4gdGhlIGNsb2NrIGhpZXJhcmNoeSBvZiBSb2NrY2hp cCBTb0NzLCBib3RoIGFjbGtzIGxpc3RlZCBoZXJlLCBhcmUgc291cmNlcyAKPiBmb3IgcGNsayBh bmQgaGNsaywgYXMgd2VsbCBhcyBzb3VyY2luZyBzb21lIG90aGVyIHBlcmlwaGVyYWwgZ2F0ZXMg ZnVydGhlciAKPiBiZWxvdyB0b28uIFNvIGZyb20gd2hhdCBJJ3ZlIHNlZW4gZnJvbSB0aGUgY2xv Y2sgZGlhZ3JhbXMsIHRoZXJlIGlzIG5vdGhpbmcgCj4gdGhhdCB3b3VsZCBjbGFpbSB0aGVzZSBj bG9ja3MgZGlyZWN0bHksIGFuZCBpdCB3b3VsZG4ndCBhbHNvIG1ha2UgYW55IHNlbnNlIHRvIAo+ IGxldCB0aGVtIGdldCBkaXNhYmxlZCBhcyB0aGVyZSB3aWxsIGFsd2F5cyBiZSBzb21ldGhpbmcg dXNpbmcgdGhlbSAoZm9yIAo+IGV4YW1wbGUgdGhlIGRyYW0tY29udHJvbGxlcikuCgpTb3VuZHMg Z29vZC4gSnVzdCBvdXQgb2YgY3VyaW9zaXR5LCB1bmRlciB3aGF0IGNpcmN1bXN0YW5jZXMgd291 bGQgeW91CndhbnQgdG8gZ2F0ZSB0aGVtPyBJcyB0aGVyZSBhIHVzZSBjYXNlIGZvciBpdD8KClJl Z2FyZHMsCk1pa2UKCj4gCj4gCj4gSGVpa28KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK