All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kan.liang@intel.com, andi@firstfloor.org,
	alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP
Date: Fri, 1 Aug 2014 15:21:20 +0200	[thread overview]
Message-ID: <20140801132120.GO18735@two.firstfloor.org> (raw)
In-Reply-To: <20140801074430.GB3588@twins.programming.kicks-ass.net>

> > NAK!
> > 
> > I already said this isn't going to ever happen.
> > 
> > Both PT and LBR are arbitrated through the kernel, therefore we can (and
> > must) deny PT when there's existing LBR usage and vice versa.
> > 
> > We will not hijack resources like this full stop end of story.
> > 
> > Fuck hardware/BIOS, they should _NOT_ be touching this.
> > 
> > The 3 people in the world with access to an x86 hardware debugger had
> > better be competent and know WTF they're doing and the BIOS can just
> > piss off right now, they should not be touching this _EVER_.


So you realize that hardware level debugging becomes impossible
if everyone starts using perf?

I dont know how anyone can construct essentially sabotaging powerful
debugging techniques ever as a good thing. In the end it'll just
lead to more buggy software (and likely hardware) for everyone.


> 
> I yelled at BIOS engineers over their PMU usage and $vendor added a BIOS
> knob to disable that, I'll yell at BIOS engineers again, just give me
> their number.
> 
> Really, say NO already.

Ok, so no technical reason, merely a "me vs you" power play.

Thank you for not stating that earlier and wasting everyone's time.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2014-08-01 13:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  9:41 [PATCH 1/3] x86 msr: msr goto extension support kan.liang
2014-07-31  9:41 ` [PATCH 2/3] x86 perf: Protect LBR msrs accessing against potential #GP kan.liang
2014-08-01  7:38   ` Peter Zijlstra
2014-08-01  7:44     ` Peter Zijlstra
2014-08-01 13:21       ` Andi Kleen [this message]
2014-08-01 18:50         ` Peter Zijlstra
2014-08-02  5:27           ` Ingo Molnar
2014-07-31  9:41 ` [PATCH 3/3] x86 perf: Protect LBR and BTS enabling kan.liang
2014-07-31 21:05 ` [PATCH 1/3] x86 msr: msr goto extension support Andy Lutomirski
2014-08-01  8:05   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140801132120.GO18735@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.