From: Joe Thornber <thornber@redhat.com>
To: Anssi Hannula <anssi.hannula@iki.fi>
Cc: Alasdair G Kergon <agk@redhat.com>, Joe Thornber <ejt@redhat.com>,
dm-devel@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH] dm cache: fix race affecting dirty block count
Date: Fri, 1 Aug 2014 16:17:30 +0100 [thread overview]
Message-ID: <20140801151729.GA27644@debian> (raw)
In-Reply-To: <1406831487-18750-1-git-send-email-anssi.hannula@iki.fi>
On Thu, Jul 31, 2014 at 09:31:27PM +0300, Anssi Hannula wrote:
> I did notice that after a reboot (after having incorrect nr_dirty) the
> entire cache was considered to be dirty and a full writeback occurred,
> but I don't know if that was related at all.
Did you take the cache down cleanly? Normally this happens when you
shutdown without destroying the cache device first.
Patch looks good.
- Joe
next prev parent reply other threads:[~2014-08-01 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 4:07 dm-cache race on nr_dirty in set_dirty/clear_dirty? Anssi Hannula
2014-07-31 18:31 ` [PATCH] dm cache: fix race affecting dirty block count Anssi Hannula
2014-08-01 15:17 ` Joe Thornber [this message]
2014-08-01 21:02 ` Anssi Hannula
2014-08-17 20:24 ` Anssi Hannula
2014-09-05 0:11 ` [PATCH] dm cache: fix race causing dirty blocks to be marked as clean Anssi Hannula
2014-09-09 9:54 ` Joe Thornber
-- strict thread matches above, loose matches on Subject: below --
2014-08-03 2:00 [PATCH] dm cache: fix race affecting dirty block count Pranith Kumar
2014-08-03 2:08 ` Pranith Kumar
2014-08-03 2:10 ` Pranith Kumar
2014-08-03 3:33 ` Anssi Hannula
2014-08-03 4:01 ` Pranith Kumar
2014-08-04 10:48 ` Joe Thornber
2014-08-04 15:02 ` Pranith Kumar
2014-08-03 4:46 ` Pranith Kumar
2014-08-03 4:57 ` Pranith Kumar
2014-08-03 5:17 ` Pranith Kumar
2014-08-03 5:28 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801151729.GA27644@debian \
--to=thornber@redhat.com \
--cc=agk@redhat.com \
--cc=anssi.hannula@iki.fi \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.