From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH 03/19] e2fsck: use root dir for lost+found when really desperate Date: Sat, 2 Aug 2014 22:25:53 -0400 Message-ID: <20140803022553.GC24826@thunk.org> References: <20140801181139.12496.14390.stgit@birch.djwong.org> <20140801181159.12496.97356.stgit@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org To: "Darrick J. Wong" Return-path: Received: from imap.thunk.org ([74.207.234.97]:41912 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbaHCCZy (ORCPT ); Sat, 2 Aug 2014 22:25:54 -0400 Content-Disposition: inline In-Reply-To: <20140801181159.12496.97356.stgit@birch.djwong.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, Aug 01, 2014 at 11:11:59AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > If we're totally unable to allocate a lost+found directory, ask the > user if he would like to dump orphaned files in the root directory. > Hopefully this enables the user to delete enough files so that a > subsequent run of e2fsck will make more progress. Better to cram lost > files in the rootdir than the current behavior, which is to fail at > linking them in, thereby leaving them as lost files. > > Signed-off-by: Darrick J. Wong Applied, although I changed: > + printf("Delete some files and re-run e2fsck.\n\n"); to: printf(_("Delete some files and re-run e2fsck.\n\n")); for proper internationalization support. Usually, I like to run all messages through problem.c, like this: fix_problem(ctx, PR_3_PASS_HEADER, &pctx); { PR_3_PASS_HEADER, N_("Pass 3: Checking @d connectivity\n"), PROMPT_NONE, 0 }, and I may change this over at some point, but I'll leave it as a printf for now. Thanks!! - Ted