From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH 07/12] move options structure to function scope
Date: Sun, 03 Aug 2014 12:52:18 +0900 [thread overview]
Message-ID: <20140803035218.GA952@swordfish> (raw)
In-Reply-To: CAG27Bk3YC1TNt=OLOQE_jO7q6izjB3iLAjWeC3xhnXBZth9Bjg@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
Hello,
On (08/02/14 23:20), Sami Kerola wrote:
> On 2 August 2014 14:47, Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> wrote:
> >> Subject: [Powertop] [PATCH 07/12] move options structure to function scope
> >
> > what for?
>
> They've told me keeping variables in as narrow scope as possible is a
> virtue. Even if it would not be I don't see any harm of moving
> everything out of global scope when ever possible.
>
> https://www.securecoding.cert.org/confluence/display/cplusplus/DCL07-CPP.+Minimize+the+scope+of+variables+and+methods
this is different. let's keep it as is.
-ss
next reply other threads:[~2014-08-03 3:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-03 3:52 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-05 21:30 [Powertop] [PATCH 07/12] move options structure to function scope Sami Kerola
2014-08-05 12:46 Sergey Senozhatsky
2014-08-04 23:41 Alexandra Yates
2014-08-03 11:46 Sergey Senozhatsky
2014-08-03 9:34 Sami Kerola
2014-08-02 22:20 Sami Kerola
2014-08-02 13:47 Sergey Senozhatsky
2014-08-02 11:54 Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140803035218.GA952@swordfish \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.