diff for duplicates of <20140803155108.GA19710@gate.crashing.org> diff --git a/a/1.txt b/N1/1.txt index a600651..c4d0e68 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,7 +12,7 @@ Using 0x0 where you mean 0, making a #define for 0 in the first place... This all looks rather silly doesn't it. > + case OP_ZERO: -> + if((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) { +> + if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) { You either shouldn't mask at all here, or the mask is wrong (the primary op is the top six bits, not the top eight). diff --git a/a/content_digest b/N1/content_digest index 03dba76..c4b1651 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,13 @@ "ref\01406868643-26291-1-git-send-email-maddy@linux.vnet.ibm.com\0" "From\0Segher Boessenkool <segher@kernel.crashing.org>\0" "Subject\0Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Sun, 03 Aug 2014 15:51:08 +0000\0" + "Date\0Sun, 3 Aug 2014 10:51:08 -0500\0" "To\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\0" - "Cc\0agraf@suse.de" - benh@kernel.crashing.org - paulus@samba.org - linuxppc-dev@lists.ozlabs.org + "Cc\0kvm@vger.kernel.org" + agraf@suse.de kvm-ppc@vger.kernel.org - " kvm@vger.kernel.org\0" + paulus@samba.org + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "> +/*\n" @@ -25,7 +24,7 @@ "This all looks rather silly doesn't it.\n" "\n" "> +\tcase OP_ZERO:\n" - "> +\t\tif((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) {\n" + "> +\t\tif((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {\n" "\n" "You either shouldn't mask at all here, or the mask is wrong (the primary\n" "op is the top six bits, not the top eight).\n" @@ -33,4 +32,4 @@ "\n" Segher -0db8ca4d6f3a02efda3843b635fd337bd2b7e50963aacba42447e4b2ff16c7b7 +22993715880858e784e004e4c686277c9df34e8cdeb59f01a70548824de213dd
diff --git a/a/1.txt b/N2/1.txt index a600651..c4d0e68 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -12,7 +12,7 @@ Using 0x0 where you mean 0, making a #define for 0 in the first place... This all looks rather silly doesn't it. > + case OP_ZERO: -> + if((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) { +> + if((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) { You either shouldn't mask at all here, or the mask is wrong (the primary op is the top six bits, not the top eight). diff --git a/a/content_digest b/N2/content_digest index 03dba76..1437e68 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,7 @@ "ref\01406868643-26291-1-git-send-email-maddy@linux.vnet.ibm.com\0" "From\0Segher Boessenkool <segher@kernel.crashing.org>\0" "Subject\0Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Sun, 03 Aug 2014 15:51:08 +0000\0" + "Date\0Sun, 3 Aug 2014 10:51:08 -0500\0" "To\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\0" "Cc\0agraf@suse.de" benh@kernel.crashing.org @@ -25,7 +25,7 @@ "This all looks rather silly doesn't it.\n" "\n" "> +\tcase OP_ZERO:\n" - "> +\t\tif((inst & 0x00FFFF00) = KVMPPC_INST_BOOK3S_DEBUG) {\n" + "> +\t\tif((inst & 0x00FFFF00) == KVMPPC_INST_BOOK3S_DEBUG) {\n" "\n" "You either shouldn't mask at all here, or the mask is wrong (the primary\n" "op is the top six bits, not the top eight).\n" @@ -33,4 +33,4 @@ "\n" Segher -0db8ca4d6f3a02efda3843b635fd337bd2b7e50963aacba42447e4b2ff16c7b7 +6a38a67a8876e3a0adac029e53664ae4358d2b875855ad67b3961850af1044ce
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.