From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: Remove the context argument to the prep_dma_cyclic operation
Date: Mon, 4 Aug 2014 13:41:28 +0530 [thread overview]
Message-ID: <20140804081128.GL8181@intel.com> (raw)
In-Reply-To: <20140801170633.GT30282@n2100.arm.linux.org.uk>
On Fri, Aug 01, 2014 at 06:06:33PM +0100, Russell King - ARM Linux wrote:
> On Fri, Aug 01, 2014 at 10:14:28PM +0530, Vinod Koul wrote:
> > On Fri, Aug 01, 2014 at 12:20:10PM +0200, Laurent Pinchart wrote:
> > > The argument is always set to NULL and never used. Remove it.
> >
> > Thats not true.
> >
> > It was introduced in commit:
> > commit 185ecb5f4fd43911c35956d4cc7d94a1da30417f
> > Author: Alexandre Bounine <alexandre.bounine@idt.com>
> > Date: Thu Mar 8 15:35:13 2012 -0500
> >
> > dmaengine: add context parameter to prep_slave_sg and prep_dma_cyclic
> >
> > Add context parameter to device_prep_slave_sg() and device_prep_dma_cyclic()
> > interfaces to allow passing client/target specific information associated
> > with the data transfer.
> > Modify all affected DMA engine drivers.
> >
> > Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Felipe Balbi <balbi@ti.com>
> > Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
> >
> > This is still used by rapidio driver. This required some extra parameters
> > passed in struct rio_dma_ext.
> >
> > I do agree this is not very elegant.
>
> Have the rapidio folk shown any sign of implementing the cyclic DMA API?
> From what I can see from drivers/rapido/, it only uses the prep_slave_sg
> API.
No they havent so i think its good to remove the unused context argument. Will merge
this now
--
~Vinod
next prev parent reply other threads:[~2014-08-04 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 10:20 [PATCH] dmaengine: Remove the context argument to the prep_dma_cyclic operation Laurent Pinchart
2014-08-01 16:44 ` Vinod Koul
2014-08-01 17:01 ` Laurent Pinchart
2014-08-01 17:06 ` Russell King - ARM Linux
2014-08-04 8:11 ` Vinod Koul [this message]
2014-08-04 8:14 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804081128.GL8181@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.