From: Al Viro <viro@ZenIV.linux.org.uk>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ian Kent <raven@themaw.net>,
autofs@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH - V2] VFS: allow ->d_manage() to declare -EISDIR in rcu_walk mode.
Date: Mon, 4 Aug 2014 09:57:31 +0100 [thread overview]
Message-ID: <20140804085731.GP18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140804170629.5b2c9013@notabene.brown>
On Mon, Aug 04, 2014 at 05:06:29PM +1000, NeilBrown wrote:
>
> In REF-walk mode, ->d_manage can return -EISDIR to indicate
> that the dentry is not really a mount trap (or even a mount point)
> and that any mounts or any DCACHE_NEED_AUTOMOUNT flag should be
> ignored.
>
> RCU-walk mode doesn't currently support this, so if there is a dentry
> with DCACHE_NEED_AUTOMOUNT set but which shouldn't be a mount-trap,
> lookup_fast() will always drop in REF-walk mode.
>
> With this patch, an -EISDIR from ->d_manage will always cause mounts
> and automounts to be ignored, both in REF-walk and RCU-walk.
In queue. Right now I'm trying to linearize the damn acct fixes from late
April, needed to get Eric's umount-on-rmdir series into the mix safely ;-/
Hopefully I'll have something pushable by Tuesday; your patch definitely
will be in the pile.
prev parent reply other threads:[~2014-08-04 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 6:08 [PATCH] VFS: allow ->d_manage() to declare -EISDIR in rcu_walk mode NeilBrown
2014-07-30 20:16 ` Christoph Hellwig
2014-07-30 23:49 ` NeilBrown
2014-08-01 8:33 ` Dan Carpenter
2014-08-01 8:48 ` NeilBrown
2014-08-04 7:06 ` [PATCH - V2] " NeilBrown
2014-08-04 8:57 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804085731.GP18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=autofs@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=raven@themaw.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.