From: Andreas Henriksson <andreas@fatal.se>
To: Mike Frysinger <vapier@gentoo.org>
Cc: YunQiang Su <wzssyqa@gmail.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH] libmount/buildsys: move SELINUX_LIBS to LDFLAGS
Date: Mon, 4 Aug 2014 11:49:48 +0200 [thread overview]
Message-ID: <20140804094948.GA32065@fatal.se> (raw)
In-Reply-To: <7003188.HrNgjPCK9Z@vapier>
Version: 2.25-1
Hello Mike!
Thank you very much for the followup and for identifying the relevant
commit for me!
(BCCing the debian bug tracking system to close the bug report...)
On Mon, Aug 04, 2014 at 03:40:56AM -0400, Mike Frysinger wrote:
[...]
> the problem is that libmount_la_DEPENDENCIES shows up in the Makefile like:
> libmount.la: ... $(libmount_la_DEPENDENCIES) ...
>
> which means make evaluates it like so:
> libmount.la: ... -lselinux -lsepol ...
>
> which triggers the builtin library path searching of make itself:
> https://www.gnu.org/software/make/manual/make.html#Libraries_002fSearch
>
> which means it'll rewrite -lselinux into /usr/lib/libselinux.so (if it can
> find it) which is bad for multilib and cross-compiling.
>
> the easy answer is to not add LIBADD to DEPENDENCIES. which has been done
> already -- see dbf7043ea1d090d283cfd36280bb14189d8e35b1.
>
[...]
Regards,
Andreas Henriksson
prev parent reply other threads:[~2014-08-04 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 20:11 [PATCH] libmount/buildsys: move SELINUX_LIBS to LDFLAGS Andreas Henriksson
2014-08-03 13:34 ` Mike Frysinger
2014-08-03 20:23 ` Andreas Henriksson
2014-08-04 7:40 ` Mike Frysinger
2014-08-04 9:49 ` Andreas Henriksson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804094948.GA32065@fatal.se \
--to=andreas@fatal.se \
--cc=util-linux@vger.kernel.org \
--cc=vapier@gentoo.org \
--cc=wzssyqa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.