From: Joerg Roedel <jroedel@suse.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jiang Liu <jiang.liu@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] iommu/vt-d: Do not BUG_ON in intel_unmap if no domain
Date: Mon, 4 Aug 2014 13:49:48 +0200 [thread overview]
Message-ID: <20140804114948.GA8172@suse.de> (raw)
In-Reply-To: <20140804114205.GA5545@pd.tnic>
On Mon, Aug 04, 2014 at 01:42:05PM +0200, Borislav Petkov wrote:
> It is always questionable when people remove BUG_ONs because relaxing
> assertions sound like a temporary fix more often than not. Sounds to me
> that the original commit which deals with BUS_NOTIFY_DEL_DEVICE needs to
> try again with the fix. :-)
Right, but the "real" fix would be to add a bus notifier that is called
after the device driver released the device and use this one instead of
BUS_NOTIFY_DEL_DEVICE.
But that change wouldn't be suitable for -stable and just removing the
event handler for BUS_NOTIFY_DEL_DEVICE would cause resource leakage
again on hotplug, so I think this "fix" is the best for now.
We can re-add the BUG_ON when we have a real fix upstream.
Joerg
next prev parent reply other threads:[~2014-08-04 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 11:23 [PATCH] iommu/vt-d: Do not BUG_ON in intel_unmap if no domain Joerg Roedel
2014-08-04 11:23 ` Joerg Roedel
[not found] ` <1407151386-16467-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-08-04 11:42 ` Borislav Petkov
2014-08-04 11:42 ` Borislav Petkov
2014-08-04 11:49 ` Joerg Roedel [this message]
2014-08-05 11:05 ` [PATCH] iommu/vt-d: Defer domain removal if device is assigned to a driver Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804114948.GA8172@suse.de \
--to=jroedel@suse.de \
--cc=bp@alien8.de \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.