From: Dimitri Sivanich <sivanich@sgi.com>
To: Hans Wennborg <hans@hanshq.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string
Date: Mon, 4 Aug 2014 08:30:37 -0500 [thread overview]
Message-ID: <20140804133037.GA31042@sgi.com> (raw)
In-Reply-To: <1407111577-14815-1-git-send-email-hans@hanshq.net>
Decimal ("%d" without the "0x") for the ctxnum please.
Nacked-by: Dimitri Sivanich <sivanich@sgi.com>
On Sun, Aug 03, 2014 at 05:19:37PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> drivers/misc/sgi-gru/grumain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..a1ce324 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
> spin_lock(&gru->gs_asid_lock);
> BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
> asids->mt_ctxbitmap ^= ctxbitmap;
> - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
> gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
> spin_unlock(&gru->gs_asid_lock);
> spin_unlock(&gms->ms_asid_lock);
> --
> 2.0.0.526.g5318336
next prev parent reply other threads:[~2014-08-04 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 0:19 [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string Hans Wennborg
2014-08-04 13:30 ` Dimitri Sivanich [this message]
2014-08-05 0:58 ` [PATCH 1/1] " Hans Wennborg
2014-08-05 12:23 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804133037.GA31042@sgi.com \
--to=sivanich@sgi.com \
--cc=hans@hanshq.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.