From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEJDl-0006Jl-LC for qemu-devel@nongnu.org; Mon, 04 Aug 2014 10:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEJDg-0006Fl-QX for qemu-devel@nongnu.org; Mon, 04 Aug 2014 10:26:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEJDg-0006Ff-HX for qemu-devel@nongnu.org; Mon, 04 Aug 2014 10:26:36 -0400 Date: Mon, 4 Aug 2014 16:26:41 +0200 From: "Michael S. Tsirkin" Message-ID: <20140804142641.GF17674@redhat.com> References: <1406920333-8297-1-git-send-email-alex@alex.org.uk> <20140804133106.GA17436@redhat.com> <7FF57083-3331-4438-BC09-B8FF14FF0696@alex.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7FF57083-3331-4438-BC09-B8FF14FF0696@alex.org.uk> Subject: Re: [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Ryan Harper , Serge Hallyn , "quintela@redhat.com" , Libvirt , Serge Hallyn , "qemu-devel@nongnu.org" , Alexander Graf , Cole Robinson , Amit Shah , Bruce Rogers , Andreas =?iso-8859-1?Q?F=E4rber?= , "Serge E. Hallyn" On Mon, Aug 04, 2014 at 02:51:01PM +0100, Alex Bligh wrote: > > On 4 Aug 2014, at 14:31, Michael S. Tsirkin wrote: > > > On Fri, Aug 01, 2014 at 08:12:11PM +0100, Alex Bligh wrote: > >> This patch series adds inbound migrate capability from qemu-kvm version > >> 1.0. The main ideas are those set out in Cole Robinson's patch here: > >> http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20 > >> however, rather than patching statically (and breaking inbound > >> migration on existing machine types), I have added a new machine > >> type (pc-1.0-qemu-kvm) without affecting any other machine types. > >> The existing pc-1.0 machine type is renamed to pc-1.0-qemu-git, > >> with pc-1.0 becoming an alias for one or another, as selected > >> by a configure option (defaulting to pc-1.0-qemu-git, IE no > >> change). > >> > >> This requires 'hot patching' the VMStateDescription in a couple of > >> places, which in turn is less than obvious as there may be (indeed > >> are for i8259) derived classes. Whilst pretty nausea-inducing, this > >> approach has the benefit of being entirely self-contained. > > > > Ow come on. > > Just add a flag and select the appropriate format based on it, using > > field_exists. > > I don't think it is that simple. All those things are initialised well > before the command line is parsed. You initialize both and select the correct one at migration time. > Unless I'm missing what you are saying? I think you are: check how vmstate_test_use_acpi_pci_hotplug and vmstate_test_no_use_acpi_pci_hotplug are used in vmstate_acpi. > -- > Alex Bligh > > >