All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
	platform-driver-x86@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] toshiba_acpi: Add extra check to backlight code
Date: Mon, 4 Aug 2014 11:19:43 -0700	[thread overview]
Message-ID: <20140804181943.GA15598@kroah.com> (raw)
In-Reply-To: <1407165662-1971-2-git-send-email-coproscefalo@gmail.com>

On Mon, Aug 04, 2014 at 09:21:01AM -0600, Azael Avalos wrote:
> Some Toshiba models (most notably Qosmios) come with an
> incomplete backlight method where the AML code doesn't
> check for write or read commands and always returns
> HCI_SUCCESS and the actual brightness (and in some
> cases the max brightness), thus allowing the backlight
> interface to be registered without write support.
> 
> This patch changes the set_lcd_brightness function,
> checking the returned values for values greater than
> zero to avoid registering a broken backlight interface.
> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
>  drivers/platform/x86/toshiba_acpi.c | 21 +++++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

  reply	other threads:[~2014-08-04 18:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 15:21 [PATCH 0/2] toshiba_acpi: Qosmio backlight and keymap fixes Azael Avalos
2014-08-04 15:21 ` [PATCH 1/2] toshiba_acpi: Add extra check to backlight code Azael Avalos
2014-08-04 18:19   ` Greg KH [this message]
2014-08-04 15:21 ` [PATCH 2/2] toshiba_acpi: Add Qosmio X75-A to the alt keymap dmi list Azael Avalos
2014-08-04 18:19   ` Greg KH
2014-08-04 18:19 ` [PATCH 0/2] toshiba_acpi: Qosmio backlight and keymap fixes Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140804181943.GA15598@kroah.com \
    --to=greg@kroah.com \
    --cc=coproscefalo@gmail.com \
    --cc=matthew.garrett@nebula.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.