From: Greg KH <gregkh@linuxfoundation.org>
To: Kiran Padwal <kiran.padwal@smartplayin.com>
Cc: davidb@codeaurora.org, dwalker@fifo99.com, bryanh@codeaurora.org,
sboyd@codeaurora.org, jslaby@suse.cz,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: msm: fix checkpatch warnings
Date: Mon, 4 Aug 2014 11:36:50 -0700 [thread overview]
Message-ID: <20140804183650.GB19594@kroah.com> (raw)
In-Reply-To: <1407162046-29729-1-git-send-email-kiran.padwal@smartplayin.com>
On Mon, Aug 04, 2014 at 07:50:46PM +0530, Kiran Padwal wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: braces {} are not necessary for any arm of this statement
>
> WARNING: Missing a blank line after declarations
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> WARNING: else is not generally useful after a break or return
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com>
> ---
> drivers/tty/serial/msm_serial.c | 26 +++++++++++---------------
> 1 file changed, 11 insertions(+), 15 deletions(-)
That's a lot of different things all mushed into one patch. Please
break this up into "one change per patch" so we can review it better.
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-04 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 14:20 [PATCH] tty: serial: msm: fix checkpatch warnings Kiran Padwal
2014-08-04 18:36 ` Greg KH [this message]
2014-08-04 21:42 ` Frank Rowand
2014-08-04 21:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804183650.GB19594@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=jslaby@suse.cz \
--cc=kiran.padwal@smartplayin.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.