All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: trinity@vger.kernel.org
Subject: Re: [patch] perf_event_open() Linux 3.16 additions
Date: Mon, 4 Aug 2014 17:55:18 -0400	[thread overview]
Message-ID: <20140804215518.GA15670@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1408040012001.630@vincent-weaver-1.umelst.maine.edu>

On Mon, Aug 04, 2014 at 12:16:18AM -0400, Vince Weaver wrote:
 > 
 > Update perf_event_open support to add new features from the recent Linux 
 > 3.16 release.
 > 
 > Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
 > 
 > diff --git a/include/perf_event.h b/include/perf_event.h
 > index 98d2ab5..9269de2 100644
 > --- a/include/perf_event.h
 > +++ b/include/perf_event.h
 > ....
 > @@ -812,3 +820,5 @@ struct perf_branch_entry {
 >  		abort:1,    /* transaction abort */
 >  		reserved:60;
 >  };
 > +
 > +#endif /* _UAPI_LINUX_PERF_EVENT_H */

I think this endif is bogus..

$ make
  CC	syscalls/perf_event_open.o
In file included from syscalls/perf_event_open.c:16:0:
include/perf_event.h:823:2: error: #endif without #if
 #endif /* _UAPI_LINUX_PERF_EVENT_H */
  ^
make: *** [syscalls/perf_event_open.o] Error 1


Luckily I hadn't pushed that out yet. Care to respin it with that fixed,
and have a quick eyeball to make sure nothing else made it in that shouldn't have ?

thanks,

	Dave

  reply	other threads:[~2014-08-04 21:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  4:16 [patch] perf_event_open() Linux 3.16 additions Vince Weaver
2014-08-04 21:55 ` Dave Jones [this message]
2014-08-05  4:06   ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140804215518.GA15670@redhat.com \
    --to=davej@redhat.com \
    --cc=trinity@vger.kernel.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.