From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: Android sync points for i915 v2 Date: Tue, 5 Aug 2014 09:32:04 -0700 Message-ID: <20140805093204.09a08d20@jbarnes-desktop> References: <53DB3275.6010102@canonical.com> <1407194292-16218-1-git-send-email-jbarnes@virtuousgeek.org> <20140805075928.44d6a316@jbarnes-desktop> <20140805090504.417ac115@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 80CD26E23F for ; Tue, 5 Aug 2014 09:31:48 -0700 (PDT) Received: by mail-pa0-f43.google.com with SMTP id lf10so1707500pab.30 for ; Tue, 05 Aug 2014 09:31:48 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Maarten Lankhorst , Greg KH , intel-gfx , John Stultz List-Id: intel-gfx@lists.freedesktop.org On Tue, 5 Aug 2014 18:08:16 +0200 Daniel Vetter wrote: > On Tue, Aug 5, 2014 at 6:05 PM, Jesse Barnes wrote: > > But yes, I want the Android guys to try this out too. I've already > > pinged them internally to check things out. Probably the biggest > > remaining opens there would be having a timeline for the display side > > of things too that covers vblank and page flip events as fences in a > > separate namespace. > > > > Which makes me think going back to just using the Android structs > > directly might be easier... > > Why that? They should really just provide the userspace interface on top ... Because the internal implementation has the nice timeline/sync pt/fence abstraction. It just fits nicely, conceptually, with the various timelines we have in gfx. For fences, I guess we'll need separate fence contexts for display and the rings. And we can still combine them with the sync_fence api, so it should be equivalent. I'm just still thinking in terms of the Android bits and not the struct fence bits; I'll probably come around eventually. -- Jesse Barnes, Intel Open Source Technology Center