From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"peter.crosthwaite@xilinx.com" <peter.crosthwaite@xilinx.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"aliguori@amazon.com" <aliguori@amazon.com>,
"marcel.a@redhat.com" <marcel.a@redhat.com>,
Luonengjun <luonengjun@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"armbru@redhat.com" <armbru@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"av1474@comtv.ru" <av1474@comtv.ru>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dmitry@daynix.com" <dmitry@daynix.com>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
"lcapitulino@redhat.com" <lcapitulino@redhat.com>,
"afaerber@suse.de" <afaerber@suse.de>,
"dgilbert@redhat.com" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/8] CODING_STYLE: Section about conditional statement
Date: Tue, 5 Aug 2014 17:53:35 +0200 [thread overview]
Message-ID: <20140805155335.GB17278@redhat.com> (raw)
In-Reply-To: <87zjfjj5s8.fsf@linaro.org>
On Tue, Aug 05, 2014 at 04:48:18PM +0100, Alex Bennée wrote:
>
> Gonglei (Arei) writes:
>
> > Hi,
> >
> >> > Yoda conditions lack readability, and QEMU has a
> >> > strict compiler configuration for checking a common
> >> > mistake like "if (dev = NULL)". Make it a written rule.
> <snip>
> >>
> >> I know this is my suggested text, but now that I'm re-reading it, I'd
> >> recommend s/0/1/ in all three places, since comparison to 0 is one of
> >> those special cases where '!a' is faster to write than 'a == 0'.
> >>
> > Got it.
>
> Should we add explicit examples for:
>
> if (x)
> if (!x)
>
> then?
Some people prefer a != NULL and not !a.
It's easy to change all == NULL and != NULL if
people prefer this:
http://www.emn.fr/z-info/coccinelle/rules/badzero.html
> --
> Alex Bennée
next prev parent reply other threads:[~2014-08-05 15:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 7:46 [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 1/8] CODING_STYLE: Section about conditional statement arei.gonglei
2014-08-01 16:01 ` Eric Blake
2014-08-04 0:55 ` Gonglei (Arei)
2014-08-05 15:48 ` Alex Bennée
2014-08-05 15:53 ` Michael S. Tsirkin [this message]
2014-08-06 1:53 ` Gonglei (Arei)
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 2/8] usb: don't use 'Yoda conditions' arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 3/8] audio: " arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 4/8] isa-bus: " arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 5/8] " arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 6/8] spice: " arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 7/8] vl: " arei.gonglei
2014-08-01 7:46 ` [Qemu-devel] [PATCH v3 8/8] vmxnet3: " arei.gonglei
2014-08-05 14:02 ` [Qemu-trivial] [PATCH v3 for-2.2 0/8] don't use Yoda conditions Michael S. Tsirkin
2014-08-05 14:02 ` [Qemu-devel] " Michael S. Tsirkin
2014-08-06 1:47 ` [Qemu-trivial] " Gonglei (Arei)
2014-08-06 1:47 ` [Qemu-devel] " Gonglei (Arei)
2014-08-06 6:05 ` [Qemu-trivial] " Markus Armbruster
2014-08-06 6:05 ` Markus Armbruster
2014-08-06 6:57 ` [Qemu-trivial] " Michael S. Tsirkin
2014-08-06 6:57 ` Michael S. Tsirkin
2014-08-06 7:55 ` [Qemu-trivial] " Markus Armbruster
2014-08-06 7:55 ` Markus Armbruster
2014-08-06 1:53 ` [Qemu-trivial] " Eric Blake
2014-08-06 1:53 ` [Qemu-devel] " Eric Blake
2014-08-06 6:53 ` [Qemu-trivial] " Michael S. Tsirkin
2014-08-06 6:53 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805155335.GB17278@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=av1474@comtv.ru \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=marcel.a@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.