From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clk: shmobile: add missing 0x0100 for SDCKCR
Date: Wed, 06 Aug 2014 01:29:34 +0000 [thread overview]
Message-ID: <20140806012931.GD5611@verge.net.au> (raw)
In-Reply-To: <87ppgf1kgv.wl%kuninori.morimoto.gx@gmail.com>
On Tue, Aug 05, 2014 at 05:39:44PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > It is added on v3.14.
> > > I can send v2 patch (or can you add it on log area ?)
> (snip)
> > > This fixes hidden bug.
> > > No board/SoC doesn't have issue without this patch.
> >
> > Thanks. Please send v2 with the above information.
> > Also please include the id and subject of the commit that added
> > the problem. e.g. 0123456789abcdef ("clk: shmobile: blah").
> >
> > And I think that this patch needs to go via
> > Mike Turquette <mturquette@linaro.org> (CCed),
> > so please include him when you post v2.
> >
> > > > 3. Should we also fix clock-r8a7790.c and clock-r8a7791.c?
> > > > If so I can make a patch or I am happy for you to do so.
> > >
> > > I can do it, but is it possible ?
> > > I'm afraid that clock-r8axxx is used for legacy (= non-DT)
> > > But, I'm happy to send it if you say "Yes"
> >
> > Good point.
> >
> > My not very strong feeling at this point is that if it is a fix then we
> > should add it. Even if it is legacy code.
>
> I see, will send v2 which includes legacy side fix patch
Thanks. Please send separate patches for each file that updated.
I believe they should all be independent of each other.
next prev parent reply other threads:[~2014-08-06 1:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 7:09 [PATCH] clk: shmobile: add missing 0x0100 for SDCKCR Kuninori Morimoto
2014-08-05 7:17 ` Simon Horman
2014-08-05 7:25 ` Geert Uytterhoeven
2014-08-05 8:51 ` Kuninori Morimoto
2014-08-05 8:57 ` Kuninori Morimoto
2014-08-05 9:06 ` Laurent Pinchart
2014-08-06 0:32 ` Simon Horman
2014-08-06 0:39 ` Kuninori Morimoto
2014-08-06 1:29 ` Simon Horman [this message]
2014-08-06 1:32 ` Kuninori Morimoto
2014-08-06 1:41 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806012931.GD5611@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.