All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Arver <linusarver@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/7] Documentation: git-init: template directory: reword
Date: Tue, 5 Aug 2014 22:15:18 -0700	[thread overview]
Message-ID: <20140806051517.GB12559@k0> (raw)
In-Reply-To: <xmqqmwbioaeh.fsf@gitster.dls.corp.google.com>

On Tue, Aug 05, 2014 at 03:10:30PM -0700, Junio C Hamano wrote:
> Linus Arver <linusarver@gmail.com> writes:
> 
> > Signed-off-by: Linus Arver <linusarver@gmail.com>
> > ---
> 
> This seems to reword and also reformat at the same time, but was the
> latter change (i.e. to unindent the bulletted items and to remove
> blank lines between items) necessary?

No, the unindenting/removal of blank lines is a non-grammar change and
is not necessary, as it doesn't have any effect on the actual output
(html/txt/manpage).

I can either keep the same coding style with the rewording, or chop this
into two commits, one for the rewording and another for reformatting.
Which one do you suggest?

> >  Documentation/git-init.txt | 14 +++++---------
> >  1 file changed, 5 insertions(+), 9 deletions(-)
> >
> > diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt
> > index 45501d0..f21b85b 100644
> > --- a/Documentation/git-init.txt
> > +++ b/Documentation/git-init.txt
> > @@ -113,22 +113,18 @@ line, the command is run inside the directory (possibly after creating it).
> >  
> >  --
> >  
> > -
> >  TEMPLATE DIRECTORY
> >  ------------------
> >  
> >  The template directory contains files and directories that will be copied to
> >  the `$GIT_DIR` after it is created.
> >  
> > -The template directory used will be (in order):
> > -
> > - - The argument given with the `--template` option.
> > -
> > - - The contents of the `$GIT_TEMPLATE_DIR` environment variable.
> > -
> > - - The `init.templatedir` configuration variable.
> > +The template directory will be one of the following (in order):
> >  
> > - - The default template directory: `/usr/share/git-core/templates`.
> > +- the argument given with the `--template` option;
> > +- the contents of the `$GIT_TEMPLATE_DIR` environment variable;
> > +- the `init.templatedir` configuration variable; or
> > +- the default template directory: `/usr/share/git-core/templates`.
> >  
> >  The default template directory includes some directory structure, some
> >  suggested "exclude patterns", and copies of sample "hook" files.

  reply	other threads:[~2014-08-06  5:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-02 18:06 [PATCH] lots of documentation fixes/rewordings in git-init(1) Linus Arver
2014-08-02 18:06 ` [PATCH 1/7] Documentation: git-init: typographical fixes Linus Arver
2014-08-05 22:06   ` Junio C Hamano
2014-08-06  4:58     ` Linus Arver
2014-08-02 18:06 ` [PATCH 2/7] Documentation: git-init: list items facelift Linus Arver
2014-08-02 18:06 ` [PATCH 3/7] Documentation: git-init: template directory: reword Linus Arver
2014-08-05 22:10   ` Junio C Hamano
2014-08-06  5:15     ` Linus Arver [this message]
2014-08-06 17:21       ` Junio C Hamano
2014-08-08 16:36         ` Linus Arver
2014-08-02 18:06 ` [PATCH 4/7] Documentation: git-init: --separate-git-dir: clarify Linus Arver
2014-08-05 22:12   ` Junio C Hamano
2014-08-06  5:21     ` Linus Arver
2014-08-06 17:35       ` Junio C Hamano
2014-08-08 16:42         ` Linus Arver
2014-08-02 18:06 ` [PATCH 5/7] Documentation: git-init: reword parenthetical statements Linus Arver
2014-08-02 18:06 ` [PATCH 6/7] Documentation: git-init: template directory: reword and cross-reference Linus Arver
2014-08-02 18:06 ` [PATCH 7/7] Documentation: git-init: flesh out example Linus Arver
2014-08-05 22:14   ` Junio C Hamano
2014-08-06  5:34     ` Linus Arver
2014-08-06 17:41       ` Junio C Hamano
2014-08-08 16:49         ` Linus Arver
2014-08-08 17:29 ` [PATCH v2] lots of documentation fixes/rewordings in git-init(1) Linus Arver
2014-08-08 17:29   ` [PATCH v2 1/7] Documentation: git-init: typographical fixes Linus Arver
2014-08-08 17:29   ` [PATCH v2 2/7] Documentation: git-init: list items facelift Linus Arver
2014-08-08 17:29   ` [PATCH v2 3/7] Documentation: git-init: template directory: reword Linus Arver
2014-08-08 17:29   ` [PATCH v2 4/7] Documentation: git-init: --separate-git-dir: clarify Linus Arver
2014-08-08 17:29   ` [PATCH v2 5/7] Documentation: git-init: reword parenthetical statements Linus Arver
2014-08-08 17:29   ` [PATCH v2 6/7] Documentation: git-init: template directory: reword and cross-reference Linus Arver
2014-08-08 17:29   ` [PATCH v2 7/7] Documentation: git-init: flesh out example Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140806051517.GB12559@k0 \
    --to=linusarver@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.