From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/15] drm/i915: Upgrade execbuffer fail after resume failure to EIO Date: Wed, 6 Aug 2014 10:39:16 +0200 Message-ID: <20140806083916.GA8727@phenom.ffwll.local> References: <1407250286-1801-1-git-send-email-rodrigo.vivi@intel.com> <1407250286-1801-4-git-send-email-rodrigo.vivi@intel.com> <20140806075645.GQ8727@phenom.ffwll.local> <20140806081232.GE15200@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DBE36E5A7 for ; Wed, 6 Aug 2014 01:39:05 -0700 (PDT) Received: by mail-wi0-f182.google.com with SMTP id d1so2793680wiv.9 for ; Wed, 06 Aug 2014 01:39:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140806081232.GE15200@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 06, 2014 at 09:12:32AM +0100, Chris Wilson wrote: > On Wed, Aug 06, 2014 at 09:56:45AM +0200, Daniel Vetter wrote: > > On Tue, Aug 05, 2014 at 07:51:14AM -0700, Rodrigo Vivi wrote: > > > From: Chris Wilson > > > > > > If we try to execute on a known ring, but it has failed to be > > > initialised correctly, report that the GPU is hung rather than the > > > command invalid. This leaves us reporting EINVAL only if the user > > > requests execution on a ring that is not supported by the device. > > > > > > This should prevent UXA from getting stuck in a null render loop after a > > > failed resume. > > > > > > v2 (Rodrigo): Fix conflict and add VCS2 ring and > > > s/intel_ring_buffer/intel_engine_cs. > > > > > > Reported-by: Jiri Kosina > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=76554 > > > Signed-off-by: Chris Wilson > > > Signed-off-by: Rodrigo Vivi > > > > This isn't required any more, see > > > > commit 074c6adaf4e7d1423d373bd5d1afc20b683cb4d0 > > Author: Chris Wilson > > Date: Wed Apr 9 09:19:43 2014 +0100 > > > > drm/i915: Mark device as wedged if we fail to resume > > > > for the alternate merged patch. > > Hmm, there is still a path that ends here, but the example above is > already fixed as you say. We have the EIO check both in the resume and driver load paths. Which other path are we missing? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch