From: chrubis@suse.cz
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] waitid/waitid02.c: Add new ECHILD errno test
Date: Wed, 6 Aug 2014 13:20:28 +0200 [thread overview]
Message-ID: <20140806112028.GA18182@rei> (raw)
In-Reply-To: <1404120652.2132.20.camel@G08JYZSD130126>
Hi!
> > Hi,
> >
> > looks good to me. I'm assuming the reason for setup/cleanup
> > is that you wanted some unrelated child to be present.
> >
>
> Hi,
> Thank you for your review and test. :)
> As you can see, there has been a test for ECHILD in waitid02.c. That
> test for idtype and id (waitid()) does not exist.
> In this patch, the process calls fork to get a child, but it waits for
> the other process, then ECHILD would return. After the test, calling
> cleanup. That test for idtype and id (waitid()) is not a child of the
> calling process.
I've modified the commit message to explain why we keep child waiting in
the background and pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-08-06 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 8:18 [LTP] [PATCH] waitid/waitid02.c: Add new ECHILD errno test Zeng Linggang
2014-06-30 8:38 ` Jan Stancek
2014-06-30 9:30 ` Zeng Linggang
2014-08-06 11:20 ` chrubis [this message]
2014-08-06 10:19 ` Zeng Linggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806112028.GA18182@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=zenglg.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.