From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 4/5] kvmtool: Handle exit reason KVM_EXIT_SYSTEM_EVENT Date: Wed, 6 Aug 2014 13:53:26 +0100 Message-ID: <20140806125326.GP25953@arm.com> References: <1407228599-25065-1-git-send-email-anup.patel@linaro.org> <1407228599-25065-5-git-send-email-anup.patel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "patches@apm.com" , Marc Zyngier , "penberg@kernel.org" , "christoffer.dall@linaro.org" , "pranavkumar@linaro.org" To: Anup Patel Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:59704 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbaHFMxY (ORCPT ); Wed, 6 Aug 2014 08:53:24 -0400 Content-Disposition: inline In-Reply-To: <1407228599-25065-5-git-send-email-anup.patel@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 05, 2014 at 09:49:58AM +0100, Anup Patel wrote: > The KVM_EXIT_SYSTEM_EVENT exit reason was added to define > architecture independent system-wide events for a Guest. > > Currently, it is used by in-kernel PSCI-0.2 emulation of > KVM ARM/ARM64 to inform user space about PSCI SYSTEM_OFF > or PSCI SYSTEM_RESET request. > > For now, we simply treat all system-wide guest events as > same and shutdown the guest upon KVM_EXIT_SYSTEM_EVENT. > > Signed-off-by: Pranavkumar Sawargaonkar > Signed-off-by: Anup Patel > --- > tools/kvm/kvm-cpu.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/kvm/kvm-cpu.c b/tools/kvm/kvm-cpu.c > index ee0a8ec..e20ee4b 100644 > --- a/tools/kvm/kvm-cpu.c > +++ b/tools/kvm/kvm-cpu.c > @@ -160,6 +160,12 @@ int kvm_cpu__start(struct kvm_cpu *cpu) > goto exit_kvm; > case KVM_EXIT_SHUTDOWN: > goto exit_kvm; > + case KVM_EXIT_SYSTEM_EVENT: > + /* > + * Treat both SHUTDOWN & RESET system events > + * as shutdown request. > + */ > + goto exit_kvm; Can we figure out whether this was a SHUTDOWN or RESET request? If so, printing a message for the latter "RESET request received -- exiting KVM" might be informative. Will