From: Richard Cochran <richardcochran@gmail.com>
To: "Koehrer Mathias (ETAS/ESW5)" <mathias.koehrer@etas.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Nick Krause <xerofoify@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support
Date: Wed, 6 Aug 2014 21:17:44 +0200 [thread overview]
Message-ID: <20140806191744.GB6611@netboy> (raw)
In-Reply-To: <bbcbf584e3624059bf7a0d2186fec6b4@FE-MBX1012.de.bosch.com>
On Wed, Aug 06, 2014 at 02:32:16PM +0000, Koehrer Mathias (ETAS/ESW5) wrote:
> With the Intel 82527EI (driver: e1000e) there is an issue when running
> the ptpd2 program, that leads to a kernel oops.
> The reason is here that in e1000_xmit_frame() a work queue will be
> scheduled that has not been initialized in this case.
> The work queue "tx_hwstamp_work" will only be initialized if
> adapter->flags & FLAG_HAS_HW_TIMESTAMP set.
> This check is missing in e1000_xmit_frame().
Why all the ragged lines? Better to use an editor that knows how to
justify a paragraph, more like this:
With the Intel 82527EI (driver: e1000e) there is an issue when running
the ptpd2 program, that leads to a kernel oops. The reason is here
that in e1000_xmit_frame() a work queue will be scheduled that has not
been initialized in this case. The work queue "tx_hwstamp_work" will
only be initialized if adapter->flags & FLAG_HAS_HW_TIMESTAMP set.
This check is missing in e1000_xmit_frame().
That not only looks nicer, but it is also more readable.
Thanks,
Richard
next prev parent reply other threads:[~2014-08-06 19:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 14:32 [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support Koehrer Mathias (ETAS/ESW5)
2014-08-06 19:17 ` Richard Cochran [this message]
[not found] ` <CAPDOMVjYkfM49E9DM0=SDDRncLQbXxR8NQE9SrsW++YycMGU5w@mail.gmail.com>
2014-08-06 19:32 ` Richard Cochran
[not found] ` <CAPDOMViFCifeUoOgExuG7Q6_ObGj20g59siyMxWeKN=Zr2Kbdg@mail.gmail.com>
2014-08-06 19:54 ` Richard Cochran
2014-08-07 6:10 ` Koehrer Mathias (ETAS/ESW5)
2014-08-07 6:20 ` Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2014-08-06 14:27 Koehrer Mathias (ETAS/ESW5)
2014-08-06 14:30 ` Sergei Shtylyov
2014-08-06 15:09 ` Henrique de Moraes Holschuh
2014-08-06 15:21 ` Alexander Duyck
2014-08-06 15:26 ` Alexander Duyck
[not found] ` <CAPDOMVgHmQeqOGj1MegRa=gusGXMn5t7cwCNnutpc1_q_fzyYg@mail.gmail.com>
2014-08-06 20:19 ` Alexander Duyck
2014-08-06 13:56 Koehrer Mathias (ETAS/ESW5)
2014-08-06 13:56 ` Koehrer Mathias (ETAS/ESW5)
2014-08-06 14:05 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806191744.GB6611@netboy \
--to=richardcochran@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.koehrer@etas.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.