Re: [meta-oe][PATCH 5/5] mariadb: update to 5.5.38

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 5447 bytes --]

On Tue, Aug 05, 2014 at 02:20:46PM +0100, Paul Eggleton wrote:
> * Upstream switched from autotools to cmake
> * Separate build dir and parallel make now work
> * Library versioning no longer used for plugins; other libtool cruft
>   gone
> * Proper upstream initscript
> * Plugins moved from client library package to mariadb-server package
>   (matches how Fedora packages these)
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  ...b-native_5.1.67.bb => mariadb-native_5.5.38.bb} |   5 +-
>  .../mysql/mariadb/Makefile.am.patch                |  19 -
>  .../mariadb/avoid-plugin-options-warnings.patch    |  17 -
>  .../mysql/mariadb/configure-ps-cache-check.patch   |  27 --
>  .../mysql/mariadb/configure.in.patch               |  13 -
>  .../mysql/mariadb/fix-cmake-module-path.patch      |  29 ++
>  .../mysql/mariadb/fix-cve-2013-1861-1.patch        | 174 ---------
>  .../mysql/mariadb/fix-cve-2013-1861-2.patch        | 257 -------------
>  .../mysql/mariadb/fix-link-error-ub1310.patch      |  37 --
>  .../mysql/mariadb/fix-mysqlclient-r-version.patch  | 161 ++++++++
>  .../mysql/mariadb/fix_host_path.patch              |  37 --
>  .../recipes-support/mysql/mariadb/misc.m4.patch    |  13 -
>  meta-oe/recipes-support/mysql/mariadb/my.cnf       |   1 +
>  meta-oe/recipes-support/mysql/mariadb/mysqld.sh    |  24 --
>  .../recipes-support/mysql/mariadb/plug.in.patch    | 405 ---------------------
>  .../mysql/mariadb/remove-bad-path.patch            |  18 +
>  ...orage-forbids-absolute-addresses-on-IA-32.patch |  44 ---
>  .../mariadb/zlib-let-libdir-configurable.patch     |  63 ----
>  .../mysql/{mariadb_5.1.67.bb => mariadb_5.5.38.bb} |   2 +
>  .../{mariadb_5.1.67.inc => mariadb_5.5.38.inc}     | 113 +++---
>  20 files changed, 273 insertions(+), 1186 deletions(-)
>  rename meta-oe/recipes-support/mysql/{mariadb-native_5.1.67.bb => mariadb-native_5.5.38.bb} (71%)
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/Makefile.am.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/avoid-plugin-options-warnings.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/configure-ps-cache-check.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/configure.in.patch
>  create mode 100644 meta-oe/recipes-support/mysql/mariadb/fix-cmake-module-path.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/fix-cve-2013-1861-1.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/fix-cve-2013-1861-2.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/fix-link-error-ub1310.patch
>  create mode 100644 meta-oe/recipes-support/mysql/mariadb/fix-mysqlclient-r-version.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/fix_host_path.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/misc.m4.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/mysqld.sh
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/plug.in.patch
>  create mode 100644 meta-oe/recipes-support/mysql/mariadb/remove-bad-path.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/storage-forbids-absolute-addresses-on-IA-32.patch
>  delete mode 100644 meta-oe/recipes-support/mysql/mariadb/zlib-let-libdir-configurable.patch
>  rename meta-oe/recipes-support/mysql/{mariadb_5.1.67.bb => mariadb_5.5.38.bb} (94%)
>  rename meta-oe/recipes-support/mysql/{mariadb_5.1.67.inc => mariadb_5.5.38.inc} (68%)

We've already discussed this on IRC, here is more details:

19:08:49 < JaMa> bluelightning: ping, mariadb is failing here (when building after world, not with minimal deps):
19:08:51 < JaMa> mariadb/5.5.38-r0/build'
19:08:51 < JaMa> | make -f dbug/CMakeFiles/t.dir/build.make dbug/CMakeFiles/t.dir/build
19:08:51 < JaMa> | ./factorial: 1: ./factorial: Syntax error: word unexpected (expecting ")")
19:08:51 < JaMa> | make[2]: *** [dbug/output1.r] Error 2
19:09:05 < JaMa> bluelightning: have you seen something like that before in your builds?
19:09:14 < bluelightning> I haven't, no
19:09:29 < bluelightning> I wonder what triggers it...
19:10:16 < JaMa> I would compare log.do_configure to see what's new, but both TMPDIRs are already gone so it will take some time
19:11:24 < bluelightning> hmm, ok... well I'm happy to hold until we figure out where the issue is

Failing version autodetected boost:
$ diff -uNr temp/log.do_configure
--- mariadb/5.5.38-r0/temp/log.do_configure.fail 2014-08-06 11:44:44.426248399 -0700
+++ mariadb/5.5.38-r0/temp/log.do_configure.ok   2014-08-06 11:57:23.110273393 -0700
@@ -727,9 +727,7 @@
 -- Looking for io_queue_init in aio - not found
 -- Check size of pthread_t
 -- Check size of pthread_t - done
--- Boost version: 1.55.0
--- Performing Test BOOST_OK
--- Performing Test BOOST_OK - Failed
+-- Could NOT find Boost
 -- Looking for include file netdb.h
 -- Looking for include file netdb.h - found
 -- Looking for include file security/pam_appl.h

Maybe that's not the only difference. Let me know if you can reproduce the issue after building boost before mariadb.

When it doesn't fail, it also reports some more autodetected dependencies:
WARNING: QA Issue: mariadb-client rdepends on readline but its not a build dependency? [build-deps]
WARNING: QA Issue: mariadb-leftovers rdepends on readline but its not a build dependency? [build-deps]

Regards,

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]