From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel/simple: add optronics B101XTN01.0 Date: Thu, 7 Aug 2014 09:33:27 +0200 Message-ID: <20140807073326.GF17340@ulmo> References: <1407357090-3801-1-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1024609984==" Return-path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 667E789F63 for ; Thu, 7 Aug 2014 00:33:30 -0700 (PDT) Received: by mail-wg0-f50.google.com with SMTP id n12so3683093wgh.33 for ; Thu, 07 Aug 2014 00:33:29 -0700 (PDT) In-Reply-To: <1407357090-3801-1-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1024609984== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A9z/3b/E4MkkD+7G" Content-Disposition: inline --A9z/3b/E4MkkD+7G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 06, 2014 at 04:31:30PM -0400, Rob Clark wrote: > LVDS panel, make/model described as: >=20 > AU Optronics Corporation - B101XTN01.0 (H/W:0A) >=20 > See: > http://www.encore-electronic.com/media/B101XTN01.0.pdf I've made it a custom to mention which board a panel is used on in the commit message and I've requested others to do the same. The idea was that it would give some kind of indication where to find the hardware if somebody wanted to test or look at for reference. >=20 > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) This is missing device tree binding documentation. >=20 > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index a251361..16119ba 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -447,6 +447,29 @@ static const struct panel_desc samsung_ltn101nt05 = =3D { > }, > }; > =20 > +static const struct drm_display_mode optronics_lvds_mode =3D { Can you please name this according to the model for consistency with other panels? > + .clock =3D 72000, > + .hdisplay =3D 1366, > + .hsync_start =3D 1366 + 20, > + .hsync_end =3D 1366 + 20 + 70, > + .htotal =3D 1366 + 20 + 70, > + .vdisplay =3D 768, > + .vsync_start =3D 768 + 14, > + .vsync_end =3D 768 + 14 + 42, > + .vtotal =3D 768 + 14 + 42, > + .vrefresh =3D 60, > + .flags =3D DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > +}; > + > +static const struct panel_desc optronics_lvds =3D { > + .modes =3D &optronics_lvds_mode, > + .num_modes =3D 1, > + .size =3D { > + .width =3D 1366, > + .height =3D 768, This needs to be the physical dimension in mm. > + }, > +}; There's now also a new field called .bpc which contains the number of bits per color (usually 6 or 8). Can you provide that as well? According to the datasheet you linked to it should be 6. > + > static const struct of_device_id platform_of_match[] =3D { > { > .compatible =3D "auo,b101aw03", > @@ -476,6 +499,10 @@ static const struct of_device_id platform_of_match[]= =3D { > .compatible =3D "samsung,ltn101nt05", > .data =3D &samsung_ltn101nt05, > }, { > + .compatible =3D "optronics,b101xtn01", =46rom the commit message this panel is from AU Optronics, so it should use the auo vendor prefix. Thierry --A9z/3b/E4MkkD+7G Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT4yvGAAoJEN0jrNd/PrOhrX0P/1mZFpzc+OulE1qN5Jte1fgq 2CTCi7XXtmUFcCK/YksE+eMclUzqOny46iHOCG4AoTG6ZEKti9/c/1bT86W8ehUg BVGcBMNl/A1bpMWXPOED2Y5OjwAKlva8qaRNskrWPrUNlOVLfI9fwSs3PWz2viYr 8vYt6N78KKgjLjoR/7QRrn1RmsQZ0rIlr6ookB91cxK77TgcPndihLAnOwFE+foL D5yLlXBMEqFrcyBNDv0uIe3o6PPoMPHykrL9Tf3yDbHSCW/+7yCzvupw2sxkyhQI 4IBdgah5O0JcaKMYIQOPmxceMtxtaaYEz6OnE9+gfxoJj+EbXSsprOl49xoRSbjr OZqSJlV46Nse9HyDy7OCD6WV3FGAwWIMGiLT+3E8DdVB6gRofl6v1V1003VTdv7m goB/D1Szdlt9jajIBTlqmwNXHplhSDsXPGL0KAba/4POM3kZEELYVTh4GM3VJ8w+ gB0hz8uLwanSunV/KSDAVtGnyTR9PZJa0FwDYml+VNNdicvmRtWl8S07np5YKG53 rVAk7sIj3cqK87ims8fIY2oTRdwOs30wqEDVWApxSKycUDbEQreN2f3PafLBIuzz RO5GAN1KfSUp4TpgNocPMjV+r82mn8DW2w+zGcsaJ9CECe5YetfSiEHEj7Mgv2YX LBMi+jbCC459uIXte/gR =6NYY -----END PGP SIGNATURE----- --A9z/3b/E4MkkD+7G-- --===============1024609984== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1024609984==--