From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: WARN_ON_ONCE(in_nmi()) hit in irq_work_queue_on
Date: Thu, 7 Aug 2014 10:13:21 +0200 [thread overview]
Message-ID: <20140807081321.GI19379@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140806234456.GA17015@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Thu, Aug 07, 2014 at 01:44:58AM +0200, Frederic Weisbecker wrote:
> In fact the problem has arised since the recent irq work patches I did.
No, those just added the WARN, previously we send the resched IPI, and
that's equally wrong from NMI context.
> There I've changed tick_nohz_full_kick() to use irq_work_queue_on() instead
> of irq_work_queue() so it has become NMI unsafe by accident.
>
> So I'd rather suggest this instead of queuing two levels of irq_work:
> +void tick_nohz_full_kick(void)
> +{
> + if (!tick_nohz_full_cpu(smp_processor_id()))
> + irq_work_queue(&__get_cpu_var(nohz_full_kick_work));
> +}
Indeed, that's better. Thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-08-07 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 16:21 WARN_ON_ONCE(in_nmi()) hit in irq_work_queue_on Dave Jones
2014-08-06 16:46 ` Peter Zijlstra
2014-08-06 16:56 ` Peter Zijlstra
2014-08-06 17:01 ` Peter Zijlstra
2014-08-06 23:44 ` Frederic Weisbecker
2014-08-07 8:13 ` Peter Zijlstra [this message]
2014-08-07 12:58 ` Frederic Weisbecker
2014-08-07 13:15 ` Peter Zijlstra
2014-08-07 13:18 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807081321.GI19379@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davej@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.