From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V2] gdb: allow building on AArch64 systems
Date: Thu, 7 Aug 2014 12:16:54 +0200 [thread overview]
Message-ID: <20140807121654.258166b7@free-electrons.com> (raw)
In-Reply-To: <20140807100915.GM23355@tarshish>
Dear Baruch Siach,
On Thu, 7 Aug 2014 13:09:15 +0300, Baruch Siach wrote:
> > We're using pwclient, which downloads the patch from patchwork and
> > applies it with "git am".
> >
> > There's basically no chance for your local commit used to generate the
> > patch to have the same SHA1 as the commit integrated in the official
> > repository. Your commit applies on commit A, but it ends up applied on
> > top of commit B. And since the SHA1 of the parent commit is part of
> > what defines the next commit and therefore it's SHA1, there's no chance
> > for your commit to have the same SHA1 in the official repo as in your
> > local repo with the workflow we have.
> >
> > SHA1 would be preserved if we were taking pull requests and merging
> > those pull requests without rebasing them. But basically, by using "git
> > am", we're rebasing all patches on top of the latest master when
> > applying them, which changes their SHA1.
>
> Alex was asking about author name, not commit ID. Compare:
>
> Author: Alex Benn?e <alex.bennee@linaro.org>
>
> Author: alex.bennee at linaro.org <alex.bennee@linaro.org>
>
> I should note that the sign-off line preserves the name correctly.
Ah yes. Then, seems possibly like a patchwork issue, since from
patchwork point of view, the author is alex.bennee at linaro.org. See
http://patchwork.ozlabs.org/patch/376942/. However, it does seem to
handle non-ASCII characters in author names if you look at
http://patchwork.ozlabs.org/patch/377013/.
http://patchwork.ozlabs.org/patch/371846/ is another example.
If you look at
http://patchwork.ozlabs.org/project/buildroot/list/?state=*, you'll see
that Alex's patch is the only case in recent times where the e-mail was
used instead of the author name.
Not sure what happened.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-08-07 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 8:42 [Buildroot] [PATCH V2] gdb: allow building on AArch64 systems Alex Bennée
2014-08-06 17:46 ` Thomas Petazzoni
2014-08-07 9:46 ` Alex Bennée
2014-08-07 10:00 ` Thomas Petazzoni
2014-08-07 10:09 ` Baruch Siach
2014-08-07 10:16 ` Thomas Petazzoni [this message]
2014-08-07 10:21 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807121654.258166b7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.