From: Vinod Koul <vinod.koul@intel.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Sugar <shuge@allwinnertech.com>
Subject: Re: linux-next: Tree for Aug 6 (sun6i-dma.c)
Date: Thu, 7 Aug 2014 19:30:01 +0530 [thread overview]
Message-ID: <20140807140000.GH8181@intel.com> (raw)
In-Reply-To: <20140807112507.GB15297@lukather>
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
On Thu, Aug 07, 2014 at 01:25:07PM +0200, Maxime Ripard wrote:
> On Thu, Aug 07, 2014 at 09:56:14AM +0200, Philipp Zabel wrote:
> > Am Mittwoch, den 06.08.2014, 10:15 -0700 schrieb Randy Dunlap:
> > > On 08/06/14 09:42, Randy Dunlap wrote:
> > > > On 08/06/14 00:28, Stephen Rothwell wrote:
> > > >> Hi all,
> > > >>
> > > >> Please do not add code intended for v3.18 until after v3.17-rc1 is
> > > >> released.
> > > >>
> > > >> Changes since 20140805:
> > > >>
> > > >
> > > > on x86_64:
> > > > when CONFIG_RESET_CONTROLLER is not enabled:
> > > >
> > > > ../drivers/dma/sun6i-dma.c: In function 'sun6i_dma_probe':
> > > > ../drivers/dma/sun6i-dma.c:911:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> > > >
> > > > Add a stub for that function?
> >
> > There is no stub for this function by choice.
> > Drivers that can accept stubbed out CONFIG_RESET_CONTROLLER functions
> > should use devm_reset_control_get_optional instead.
> >
> > > or that driver's Kconfig entry could select RESET_CONTROLLER.
> >
> > Yes, please.
>
> A depends on would be better I guess.
Patch pls :)
--
~Vinod
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-08-07 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 7:28 linux-next: Tree for Aug 6 Stephen Rothwell
2014-08-06 16:42 ` linux-next: Tree for Aug 6 (sun6i-dma.c) Randy Dunlap
2014-08-06 17:15 ` Randy Dunlap
2014-08-07 7:56 ` Philipp Zabel
2014-08-07 11:25 ` Maxime Ripard
2014-08-07 14:00 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807140000.GH8181@intel.com \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=shuge@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.