From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XFP3I-0001od-GM
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 10:52:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XFP3C-00029O-Cd
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 10:52:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38942)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XFP3C-000287-4l
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 10:52:18 -0400
Date: Thu, 7 Aug 2014 16:52:12 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140807145212.GG3374@noname.redhat.com>
References: <cover.1406150099.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1406150099.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/5] Allow VPC and VDI to be created
	over protocols
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

Am 23.07.2014 um 23:22 hat Jeff Cody geschrieben:
> Changes from v2 -> v3:
>     * Patch 2: Removed extra #ifdef __linux__ from top of file (Max)
>     * Patch 4: Removed extra #ifdef __linux__ from top of file (Max)
>     * Patch 5: Removed output from debug cruft (Max)
>     * Added Max's R-b to remaining patches
> 
> Changes from v1 -> v2:
>     * Patch 2: Use'bs' instead of 'bs->file' (Max)
>     * Patch 3: Same as patch 2 (ripple through)
>     * Patch 5: Update VDI test for static image (Kevin)
>     * Added Max's R-b to patches 1,3,4
> 
> This allows VPC and VDI to be created over protocols; currently, they use
> posix calls directly to open, seek, and write into new image files.  This
> obviously precludes them from being able to be created over a protocol, like
> glusterfs.

Thanks, applied to the block branch.

I have one general remark, though: When creating an image, there's
little reason to use bdrv_pwrite_sync() instead of bdrv_pwrite(). If it
crashes in the middle, the file will be thrown away anyway. So it only
slows things down a bit for no benefit. Might be worth a follow-up.

Kevin