From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel/simple: add optronics B101XTN01.0 Date: Thu, 7 Aug 2014 17:08:10 +0200 Message-ID: <20140807150808.GA18356@ulmo.nvidia.com> References: <1407357090-3801-1-git-send-email-robdclark@gmail.com> <20140807073326.GF17340@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1667775751==" Return-path: Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 712646E03D for ; Thu, 7 Aug 2014 08:08:15 -0700 (PDT) Received: by mail-pd0-f180.google.com with SMTP id v10so3629273pde.39 for ; Thu, 07 Aug 2014 08:08:15 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============1667775751== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 07, 2014 at 08:50:22AM -0400, Rob Clark wrote: > On Thu, Aug 7, 2014 at 3:33 AM, Thierry Reding = wrote: > > On Wed, Aug 06, 2014 at 04:31:30PM -0400, Rob Clark wrote: > >> LVDS panel, make/model described as: > >> > >> AU Optronics Corporation - B101XTN01.0 (H/W:0A) > >> > >> See: > >> http://www.encore-electronic.com/media/B101XTN01.0.pdf > > > > I've made it a custom to mention which board a panel is used on in the > > commit message and I've requested others to do the same. The idea was > > that it would give some kind of indication where to find the hardware if > > somebody wanted to test or look at for reference. >=20 > It's just a free-standing panel, which (in this case) can be plugged > to an ifc6410 (and I think various other inforce boards..) looks like > a standard(ish) 41 pin connector. Well, it certainly doesn't have to be exclusively used on a board. I guess if it isn't shipped with the IFC6410 as standard, maybe you could simply mention that it's been tested on an IFC6410. What I like to avoid is that people submit panel patches that are not tested on real hardware. > >> Signed-off-by: Rob Clark > >> --- > >> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > >> 1 file changed, 27 insertions(+) > > > > This is missing device tree binding documentation. >=20 > there is nothing new, so I assume you just mean adding the compatible > string to a list? There's no such list. You should add a new file, named after the compatible string and stick it along with all the others into Documentation/devicetree/bindings/panel. You can simply use one of the other bindings that are derived from simple-panel as template and adjust for the panel-specifics. There are a couple from AUO in that directory already, so it should be easy. > >> static const struct of_device_id platform_of_match[] =3D { > >> { > >> .compatible =3D "auo,b101aw03", > >> @@ -476,6 +499,10 @@ static const struct of_device_id platform_of_matc= h[] =3D { > >> .compatible =3D "samsung,ltn101nt05", > >> .data =3D &samsung_ltn101nt05, > >> }, { > >> + .compatible =3D "optronics,b101xtn01", > > > > From the commit message this panel is from AU Optronics, so it should > > use the auo vendor prefix. >=20 > so, "auo,b101xtn01" works for everyone? Yeah, that's consistent with the other ones from AUO, so looking good to me. Thierry --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT45ZYAAoJEN0jrNd/PrOhnl4QAKK/ac+iWRw7Ar7kflltEBSl NUGKaHytsHCTKsts4i7fJR8Z8n/tHqrwriY1YMTtx3UMWZhUw5glpk2H1I3/Gylt SQC14LIa10YgvCyKH1ckif6ig+nd5LglEf22gE64cRSeeMq/MDTfGDHO6blBBaPo vy3uAiY4gl+FoVC4I7jYvpTo3lt1IFAXmVyBTKLaoD1k9KAhZzEmT2d7hFO8TYqp z0t9t5sgNBbQE2njRGwxd0dPCBuajWVODH+4dFIjCGmTcgE5x2UE30rIElg/WFEx mfzdr5Ki0hFaDGabSU8n1aw25xgEk7PRVYCmigK2SUuiBFn0S7K0T0LV7HZAXLx7 Ae0znkF5HedcRgmOCnhQk7c/x+Pxe/sJfM6YsaoW3zZD2MSG9S1alXtcb943VyvT YnToEKrXktA93GfISsKui9X0ngcUQ6G7vjAo4+X3sRjPu6lPdOVtizVCUFse+WfR GjzW2YHnlUNjtAnK6nu9VVBSBLzljIwwuCmxrxtUt0l7ZyPN8FhCNWQ1qp1gSoAL TWlSDyy09mq+Wo1PS9Y5bCEaknAbVhkMvauDY8qdzWruDcomo3aa6FozHHBvh0LN ENut4ZDxHE69nxMJCXbjsAmMJJUDica1o5Q9hlhMjmNRdIlqSq+FIRmR2Ldl/Pnh WxcMYeSGsKrCprGbTd7d =jvHX -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx-- --===============1667775751== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1667775751==--