Re: [Qemu-devel] [RESEND PATCH v5 1/3] qga: Add guest-fsfreeze-freeze-list command

[Michael Roth <mdroth@linux.vnet.ibm.com>]

Quoting Eric Blake (2014-08-07 17:03:57)
> On 06/30/2014 03:51 PM, Tomoki Sekiyama wrote:
> > If an array of mount point paths is specified as 'mountpoints' argument
> > of guest-fsfreeze-freeze-list, qemu-ga will only freeze the file systems
> > mounted on specified paths in Linux guests. Otherwise, it works as the
> > same way as guest-fsfreeze-freeze.
> > This would be useful when the host wants to create partial disk snapshots.
> > 
> > Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > ---
> >  qga/commands-posix.c |   32 +++++++++++++++++++++++++++++++-
> >  qga/commands-win32.c |    9 +++++++++
> >  qga/qapi-schema.json |   17 +++++++++++++++++
> >  3 files changed, 57 insertions(+), 1 deletion(-)
> > 
> 
> > +++ b/qga/qapi-schema.json
> > @@ -387,6 +387,23 @@
> >    'returns': 'int' }
> >  
> >  ##
> > +# @guest-fsfreeze-freeze-list:
> > +#
> > +# Sync and freeze specified guest filesystems
> > +#
> > +# @mountpoints: #optional an array of mountpoints of filesystems to be frozen.
> > +#               If omitted, every mounted filesystem is frozen.
> > +#
> > +# Returns: Number of file systems currently frozen. On error, all filesystems
> > +# will be thawed.
> > +#
> > +# Since: 2.1
> 
> This missed 2.1.  We'll need a followup patch (or rebase mdroth's
> staging tree) to bump this to 2.2.

Yikes, thanks for the quick catch. Updated the versions in qga branch
and in the pull branch that was just sent.

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org