From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFW1d-0006R5-Qk for qemu-devel@nongnu.org; Thu, 07 Aug 2014 18:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFW1X-0000eY-2D for qemu-devel@nongnu.org; Thu, 07 Aug 2014 18:19:09 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:52255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFW1W-0000eS-QI for qemu-devel@nongnu.org; Thu, 07 Aug 2014 18:19:02 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Aug 2014 16:19:02 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id E2B8D19D803E for ; Thu, 7 Aug 2014 16:18:48 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b03cxnp08026.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s77MHeJI5177646 for ; Fri, 8 Aug 2014 00:17:40 +0200 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id s77MNElo009840 for ; Thu, 7 Aug 2014 16:23:14 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <53E3F7CD.2000606@redhat.com> References: <20140630215121.7224.92913.stgit@dhcp-17-70.bos.redhat.com> <20140630215127.7224.22898.stgit@dhcp-17-70.bos.redhat.com> <53E3F7CD.2000606@redhat.com> Message-ID: <20140807221858.31931.89691@loki> Date: Thu, 07 Aug 2014 17:18:58 -0500 Subject: Re: [Qemu-devel] [RESEND PATCH v5 1/3] qga: Add guest-fsfreeze-freeze-list command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mitsuhiro.tanino@hds.com Quoting Eric Blake (2014-08-07 17:03:57) > On 06/30/2014 03:51 PM, Tomoki Sekiyama wrote: > > If an array of mount point paths is specified as 'mountpoints' argument > > of guest-fsfreeze-freeze-list, qemu-ga will only freeze the file systems > > mounted on specified paths in Linux guests. Otherwise, it works as the > > same way as guest-fsfreeze-freeze. > > This would be useful when the host wants to create partial disk snapsho= ts. > > = > > Signed-off-by: Tomoki Sekiyama > > Reviewed-by: Eric Blake > > --- > > qga/commands-posix.c | 32 +++++++++++++++++++++++++++++++- > > qga/commands-win32.c | 9 +++++++++ > > qga/qapi-schema.json | 17 +++++++++++++++++ > > 3 files changed, 57 insertions(+), 1 deletion(-) > > = > = > > +++ b/qga/qapi-schema.json > > @@ -387,6 +387,23 @@ > > 'returns': 'int' } > > = > > ## > > +# @guest-fsfreeze-freeze-list: > > +# > > +# Sync and freeze specified guest filesystems > > +# > > +# @mountpoints: #optional an array of mountpoints of filesystems to be= frozen. > > +# If omitted, every mounted filesystem is frozen. > > +# > > +# Returns: Number of file systems currently frozen. On error, all file= systems > > +# will be thawed. > > +# > > +# Since: 2.1 > = > This missed 2.1. We'll need a followup patch (or rebase mdroth's > staging tree) to bump this to 2.2. Yikes, thanks for the quick catch. Updated the versions in qga branch and in the pull branch that was just sent. > = > -- = > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org