From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbaHHEnT (ORCPT ); Fri, 8 Aug 2014 00:43:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50970 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbaHHEnS (ORCPT ); Fri, 8 Aug 2014 00:43:18 -0400 Date: Thu, 7 Aug 2014 21:42:46 -0700 From: Greg Kroah-Hartman To: Oleg Drokin Cc: Evgeny Budilovsky , devel@driverdev.osuosl.org, Andreas Dilger , Peng Tao , linux-kernel@vger.kernel.org, Lai Siyao Subject: Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field Message-ID: <20140808044246.GA3084@kroah.com> References: <87k36ltoob.fsf@gmail.com> <20140806214216.GA16530@kroah.com> <20140808034951.GA6626@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote: > Hello! > > On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote: > >> > >> This is not a critical bug and in the worst case the code here may > >> cause miss of statistics counter increase. > >> This is why I think it is not worth to backport the patch at all. > > You are right, and if this is just for some random "statistics" file, > > can we just delete the whole function? > > I hope not! > This is used all around the client to tally up various operations executed counts. Why would you do that? Why would they care? > The statistic is then used by various userspace monitoring tools. Why not use the in-kernel monitoring tools instead of creating your own? What does userspace do with that information? thanks, greg k-h